Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIV rebase update #565

Merged
merged 6 commits into from
Sep 17, 2024
Merged

PIV rebase update #565

merged 6 commits into from
Sep 17, 2024

Conversation

mmerklinger
Copy link
Contributor

This PR makes the commandline options a bit more consistent and adds help texts.

Changes

  • Remove build for Windows from CI pipeline.
  • Makes commandline options a bit more consistent among all the options for PIV.
  • Add help texts for commands and options.
  • Makes options key and format case insensitive.

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.9
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
  • added labels

Test Environment and Execution

  • OS:
  • device's model:
  • device's firmware version:

Relevant Output Example

Fixes #

@daringer
Copy link
Collaborator

This superseeds #506 , right ?
How about merging?
@sosthene-nitrokey @mmerklinger any reasons not to ?

@sosthene-nitrokey
Copy link
Contributor

sosthene-nitrokey commented Sep 16, 2024

I'm good with merging to main but it's not in the stable firmware? I would add a --experimental flag.

Not that this targets the #506 branch, not main.

@daringer
Copy link
Collaborator

ah, overseen that's not targetting main - ok, then let's merge this and then target to merge it overall including an --experimental flag

@sosthene-nitrokey sosthene-nitrokey merged commit f206e2e into piv-rebase Sep 17, 2024
8 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the piv-rebase-update branch September 17, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants