fix: Force extended length apdu for export object #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically the SE050 will never respond with more than 256 bytes when responding to a short apdu This was not an issue previously since we only ever exported keys that were smaller than that. We cannot really dynamically force the extended apdu based on the key type because this information is not available in the command.
robin-nitrokey
approved these changes
Aug 9, 2024
daringer
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the SE050 will never respond with more than 256 bytes when responding to a short apdu This was not an issue previously since we only ever exported keys that were smaller than that.
We cannot really dynamically force the extended apdu based on the key type because this information is not available in the command.