Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support credential update #99

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Support credential update #99

merged 7 commits into from
Aug 18, 2023

Conversation

szszszsz
Copy link
Member

@szszszsz szszszsz commented Aug 12, 2023

Add Initial support for the credential update
Makes RenameCredential command obsolete

Fixes #65

pynitrokey support provided in Nitrokey/pynitrokey#425

Makes RenameCredential command obsolete
@szszszsz szszszsz added the enhancement New feature or request label Aug 12, 2023
@szszszsz szszszsz changed the title Initial support for the credential update Support credential update Aug 12, 2023
src/command.rs Outdated Show resolved Hide resolved
This will allow to remove PWS fields from the FlatCredential on its update
@szszszsz szszszsz marked this pull request as draft August 16, 2023 15:20
@szszszsz szszszsz marked this pull request as ready for review August 16, 2023 17:56
src/command.rs Outdated Show resolved Hide resolved
src/credential.rs Show resolved Hide resolved
@szszszsz
Copy link
Member Author

All raised concerns are solved. Merging.

@szszszsz szszszsz merged commit e2f3c91 into main Aug 18, 2023
2 checks passed
@szszszsz szszszsz deleted the 65-update-credential-2 branch August 18, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to update credential
3 participants