Merged
Conversation
❌ Deploy Preview for roaring-ganache-c7465f failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a security-focused refactor of the Solidity side:
Rebuilt CropChain.sol with safer marketplace logic (listing, buying, withdrawing).
Applied CEI pattern to value-transfer flows so state updates happen before external ETH calls.
Added reentrancy protection (nonReentrant) on all external state-changing functions.
Added emergency pause/unpause circuit breaker for admin incident response.
Added oracle price recording + TWAP checks so buys reject prices that deviate too much (flash-loan resistance).
Added a mock attacker contract to simulate reentrancy attacks.
Added security tests proving:
reentrancy withdrawal attack is blocked,
paused contract blocks marketplace actions,
manipulated listing prices fail TWAP validation.