Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FromCabal.Name: fix libsoup attribute names #635

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Dec 4, 2024

pkgconfig-depends: libsoup-3.0 was being incorrectly resolved to libsoup attribute. Additionally, NixOS/nixpkgs#360908 renamed libsoup attribute to libsoup_2_4.

Let’s use the correct package attribute names for all libsoup pkg-config files. All libsoup dependent Haskell-packages use pkgconfig-depends with one of those names:

https://hackage.haskell.org/package/gi-soup-3.0.3/src/gi-soup.cabal
https://hackage.haskell.org/package/gi-soup-2.4.29/src/gi-soup.cabal
https://hackage.haskell.org/package/spike-0.3/src/spike.cabal

`pkgconfig-depends: libsoup-3.0` was being incorrectly resolved to `libsoup` attribute. Additionally, NixOS/nixpkgs#360908 renamed `libsoup` attribute to `libsoup_2_4`.

Let’s use the correct package attribute names for all libsoup pkg-config files. All libsoup dependent Haskell-packages use `pkgconfig-depends` with one of those names:

https://hackage.haskell.org/package/gi-soup-3.0.3/src/gi-soup.cabal
https://hackage.haskell.org/package/gi-soup-2.4.29/src/gi-soup.cabal
https://hackage.haskell.org/package/spike-0.3/src/spike.cabal
@maralorn maralorn merged commit af1bc25 into NixOS:master Dec 4, 2024
7 checks passed
@maralorn
Copy link
Member

maralorn commented Dec 4, 2024

Thank you!

@jtojnar jtojnar deleted the patch-2 branch December 4, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants