Skip to content

Fix broken link#1003

Merged
mweinelt merged 1 commit intoNixOS:mainfrom
jfly:fix-typ
Apr 11, 2026
Merged

Fix broken link#1003
mweinelt merged 1 commit intoNixOS:mainfrom
jfly:fix-typ

Conversation

@jfly
Copy link
Copy Markdown
Contributor

@jfly jfly commented Apr 11, 2026

I'm setting up zrepl on my homelab. As with every new thing, I first study our code for inspiration =)

Do we even want this? It's not necessary for transactional consistency (we already get that from zfs snapshots). From https://zrepl.github.io/configuration/snapshotting.html#postgres-checkpoint-hook

However, the Postgres manual recommends against checkpointing during normal operation. Further, the operation requires Postgres superuser privileges. zrepl users must decide on their own whether this hook is useful for them (it likely isn’t).

@jfly jfly requested a review from a team as a code owner April 11, 2026 02:32
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Apr 11, 2026

I believe I had read the docs around this, but I don't recall such details anymore, except that at some point I also wondered if we want it.

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Apr 11, 2026

We don't want the churn from the WAL in our backups, so the force a checkpoint. Every once in a while it would create unreasonable spikes between snapshots.

@mweinelt mweinelt added this pull request to the merge queue Apr 11, 2026
Merged via the queue into NixOS:main with commit 156e1d7 Apr 11, 2026
14 checks passed
@jfly
Copy link
Copy Markdown
Contributor Author

jfly commented Apr 11, 2026

Every once in a while it would create unreasonable spikes between snapshots.

Ooh, spikes as in the number of changed blocks? This is about minimizing storage consumption?

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Apr 11, 2026

Yes, storage consumption and time to sync the changes as function of the storage increase, which again increases the number of snapshots we need to keep before they can be pruned.

@jfly
Copy link
Copy Markdown
Contributor Author

jfly commented Apr 11, 2026

which again increases the number of snapshots we need to keep before they can be pruned.

Could you explain this? How would increased storage and slower syncs increase the number of snapshots we need to keep?

@mweinelt
Copy link
Copy Markdown
Member

We can't delete snapshots that are not transfered yet.

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Apr 11, 2026

I wonder if this might interact badly with some long and large RW transactions which we produce (about half an hour on some evals, I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants