Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchTree: Distinguish between fetchGit and fetchTree consistently in error messages #12375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edolstra
Copy link
Member

Motivation

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Jan 28, 2025
@edolstra edolstra changed the title fetchTree: Distinguish between fetchGit and fetchTree consistently fetchTree: Distinguish between fetchGit and fetchTree consistently in error messages Jan 28, 2025
@@ -63,7 +63,7 @@ function characterisationTestExit() {
echo ''
echo 'You can rerun this test with:'
echo ''
echo " _NIX_TEST_ACCEPT=1 make tests/functional/${TEST_NAME}.sh.test"
echo " _NIX_TEST_ACCEPT=1 meson test lang"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to work in https://github.com/NixOS/nix/pull/12372/files#diff-36724f93532488ab13c7db3ea46b7849517158c13888e2811965d18c8bcd4a6bR74

Suggested change
echo " _NIX_TEST_ACCEPT=1 meson test lang"
echo " _NIX_TEST_ACCEPT=1 meson test ${TEST_NAME}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
Status: To triage
Development

Successfully merging this pull request may close these issues.

2 participants