Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring #1596

Merged
merged 5 commits into from
Dec 1, 2024
Merged

Small refactoring #1596

merged 5 commits into from
Dec 1, 2024

Conversation

SvMak
Copy link
Contributor

@SvMak SvMak commented Nov 30, 2024

Fix

  • file path for inlineSvg plugin.

Add

  • Link component.

Update

  • twitter to X icon and URL for footer;
  • moved header & footer to components folder (logically these are not layouts);
  • small styles improvements.

thilobillerbeck
thilobillerbeck approved these changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@thilobillerbeck thilobillerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about the sticky header, since I remember there was a discussion once on whether we want to have this or not, but I guess it's a good change for now.

The rest looks fine. Love to see your next PRs.

@thilobillerbeck thilobillerbeck merged commit b7da0a6 into NixOS:main Dec 1, 2024
2 checks passed
@SvMak SvMak deleted the small-refactoring branch December 1, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thilobillerbeck thilobillerbeck thilobillerbeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SvMak @thilobillerbeck