Skip to content

Conversation

@infinisil
Copy link
Member

Migrating nomination from #50 (comment) as part of switching to PR-based process: #34

I'm nominating @mdaniels5757 for commit access. He has only been contributing since May this year, but has already been acting like a committer. On paper, he is only maintaining four packages himself - but with 265 reviewed and 236 merged PRs, he is clearly taking care of Nixpkgs as a whole.

He is doing a lot of the daily maintenance work that the project needs: Package updates, backports and cleanups like dropping packages or inactive maintainers. With commit access, he could work much more efficiently by directly pushing to r-ryantm PRs instead of replacing them. He has not worked much on NixOS or more fundamental changes, I think, but has demonstrated to be well aware of our contribution guidelines from the very beginning. I trust his judgement for which things he'd be comfortable committing.

My interactions with him were always positive, he communicates clearly and politely and would be good addition to the team!

Originally posted by @wolfgangwalther in #50

Thank you for the nomination, @wolfgangwalther!

As you said, I've mostly been focused on updates and cleanups (most recently dealing with r-ryantm updates that were in some way defective). A commit bit would be a great help with these: both to merge others' PRs, and to be able to undraft and push to r-ryantm's PRs.

A few of my other contributions you may have noticed:

And a few of my reviews:

I understand that I haven't been doing this for that long, and that there's plenty I don't know. (Of course, I would not merge things in areas I'm not confident that I understand!) But I think there's still plenty that a commit bit would help me do for nixpkgs.

Originally posted by @mdaniels5757 in #50

Migrating nomination from #50 (comment) as part of switching to PR-based process: #34

Co-Authored-By: Wolfgang Walther <walther@technowledgy.de>
Copy link

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I co-sign what Wolfgang wrote. Let's say yes to @mdaniels5757.

Copy link
Member

@niklaskorz niklaskorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael was of great help in dealing with the Tarmageddon Rust CVE in nixpkgs

Copy link

@iedame iedame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael will be a great addition to nixpkgs!

@wolfgangwalther
Copy link
Contributor

Approved. Thank you for your contributions!

We recognize that the tenure in the project is shorter here than most new committers, but believe that the widely‐scoped maintenance and review work is valuable and worth empowering.

@wolfgangwalther wolfgangwalther merged commit b866559 into main Dec 11, 2025
1 check passed
@wolfgangwalther wolfgangwalther deleted the nominate-mdaniels5757 branch December 11, 2025 13:06
@philiptaron
Copy link

Congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants