Skip to content

Commit

Permalink
nixos/README.md: add guideline to link to nixos tests from packages
Browse files Browse the repository at this point in the history
  • Loading branch information
pbsds authored and fricklerhandwerk committed Sep 26, 2024
1 parent 8f8f170 commit c7f9378
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion nixos/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ Reviewing process:

- Ensure that all file paths [fit the guidelines](../CONTRIBUTING.md#file-naming-and-organisation).
- Ensure that the module tests, if any, are succeeding.
- Ensure that new module tests are added to the package `passthru.tests`.
- Ensure that the introduced options are correct.
- Type should be appropriate (string related types differs in their merging capabilities, `loaOf` and `string` types are deprecated).
- Description, default and example should be provided.
Expand All @@ -95,7 +96,8 @@ Sample template for a new module review is provided below.
##### Reviewed points

- [ ] module path fits the guidelines
- [ ] module tests succeed on ARCHITECTURE
- [ ] module tests, if any, succeed on ARCHITECTURE
- [ ] module tests, if any, are added to package `passthru.tests`
- [ ] options have appropriate types
- [ ] options have default
- [ ] options have example
Expand Down

0 comments on commit c7f9378

Please sign in to comment.