dbeaver: 7.3.2 -> 7.3.5, build from source and add darwin build#108417
dbeaver: 7.3.2 -> 7.3.5, build from source and add darwin build#108417samueldr merged 6 commits intoNixOS:masterfrom
Conversation
055c308 to
4a81a87
Compare
3c6b567 to
aa56eac
Compare
|
Nice! I did not test in depth, but ran it on the machine I used it previously, it picked up the old profile and worked just as expected. Good work on figuring out a scheme to make the maven calls reproducible. For fun I tried to run it on aarch64-linux, the maven artifacts were verified to fetch reproducibly, but a dependency isn't yet available for aarch64, so that didn't work for the time being. (dbeaver/dbeaver#7606) I haven't taken the time to look at the changes in depth either, but as far as the end-product working, it seems to work just fine. |
aa56eac to
a3de4d5
Compare
a3de4d5 to
580949a
Compare
|
Updated to latest release https://dbeaver.io/2021/01/31/dbeaver-7-3-4/ |
580949a to
fdeca0a
Compare
|
Updated to latest release https://dbeaver.io/2021/02/14/dbeaver-7-3-5/ |
|
Any reason to wait on merging this? @samueldr want to press merge? |
|
I was hoping that someone else who knew more about the Java ecosystem would chime in, or to have other approvals along the way... And I forgot about it after the initial look. |
|
I'm not sure, but that's likely. Github tells you somewhere in the UI which issues will be closed, when the messages are formatted "correctly". I generally end-up making a list like what follows, otherwise Github sometimes doesn't do the right thing. - Fixes #xxx
- Fixes #xxy |
Motivation for this change
I finally got around to building dbeaver from source (resolving #34182). Here one problem occurred: maven needs JDK 11 as the jdk dependency to fix:
Using JDK < 15 also fixes the build because
AlgorithmId.md5WithRSAEncryption_oidwas removed with JDK 15 and #107547 did update the default JDK to version 15:In addition, I've included some modifications for a macOS build (resolving #98631), since I have access to a Mac for a short time.
Could someone more familiar with the macOS side of things check my changes?
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)