Skip to content

jdk14: init (restore)#116882

Closed
roberth wants to merge 1 commit intoNixOS:masterfrom
hercules-ci:jdk14
Closed

jdk14: init (restore)#116882
roberth wants to merge 1 commit intoNixOS:masterfrom
hercules-ci:jdk14

Conversation

@roberth
Copy link
Member

@roberth roberth commented Mar 19, 2021

Motivation for this change

It was removed incompletely, while some packages do not support
jdk15 yet, one of them being logstash.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It was removed incompletely, while some packages do not support
jdk15 yet, one of them being logstash.
@flokli
Copy link
Member

flokli commented Mar 19, 2021

We shouldn't be packaging Java 14 (at least not while marking it as insecure) - it stopped getting security updates in September 2020.

According to their website, logstash should work with openjdk11 too. (which still gets security updates till October 2024 (for AdoptOpenJDK).

@roberth which other packages regressed? I'd prefer if we'd use jdk 11 for those instead of re-introducing an insecure JDK version.

Also cc @jerith666 due to 13e3d2b.

@roberth
Copy link
Member Author

roberth commented Mar 19, 2021

I thought jdk14 was removed by mistake. #107547 did not have a motivation section.

@flokli
Copy link
Member

flokli commented Mar 19, 2021

Yeah, true. Do you think we can switch logstash to openjdk11?

@roberth
Copy link
Member Author

roberth commented Mar 19, 2021

According to logstash docs, yes. See #116936
I also noticed #116935

@roberth roberth closed this Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments