Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_7zz: 22.00 -> 22.01; build on macOS #146010

Merged
merged 3 commits into from
Jul 23, 2022
Merged

_7zz: 22.00 -> 22.01; build on macOS #146010

merged 3 commits into from
Jul 23, 2022

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Nov 14, 2021

Motivation for this change

Right now it fails on x86_64-darwin with the following error:

../../../Windows/FileDir.cpp:1009:10: error: use of undeclared identifier 'utimensat'
  return utimensat(AT_FDCWD, path, times, flags) == 0

According to this issue, utimensat is only available on macOS SDK 10.13+.

So we probably need to wait until this issue is fixed: #101229

Maybe this works in aarch64-darwin though, since we use a newer SDK for it? If someone is interested to test, you're welcome.

Edit: working fine after the introduction of darwin.apple_sdk_11_0.callPackage, and also some additional patching.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@domenkozar
Copy link
Member

@ofborg build 7zz

@thiagokokada
Copy link
Contributor Author

@ofborg build _7zz

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@smancill
Copy link
Contributor

Can this maybe be revived now that there is darwin.apple_sdk_11_0?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 23, 2022
@thiagokokada
Copy link
Contributor Author

Can this maybe be revived now that there is darwin.apple_sdk_11_0?

Let me do a rebase and test.

@thiagokokada
Copy link
Contributor Author

Can this maybe be revived now that there is darwin.apple_sdk_11_0?

Done. Tested on my x86_64-darwin system. Would like an input from someone with aarch64-darwin.

Will also test on x86_64-linux later to make sure my changes didn't break it.

@thiagokokada thiagokokada changed the title 7zz: build on macOS _7zz: 22.00 -> 22.01; build on macOS Jul 23, 2022
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 146010 run on x86_64-linux 1

1 package built:
  • _7zz

@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 146010 run on x86_64-darwin 1

1 package built:
  • _7zz

@superherointj
Copy link
Contributor

Result of nixpkgs-review pr 146010 run on x86_64-linux 1

1 package built:
  • _7zz

@siraben
Copy link
Member

siraben commented Jul 23, 2022

Result of nixpkgs-review pr 146010 run on aarch64-darwin 1

1 package built:
  • _7zz

@thiagokokada thiagokokada merged commit 6e52e64 into NixOS:master Jul 23, 2022
@thiagokokada thiagokokada deleted the build-7zz-macos branch July 23, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update macOS SDK
7 participants