ncdu: 1.16 -> 2.0

[Atemu]

Motivation for this change

Currently broken upstream it seems: https://code.blicky.net/yorhel/ncdu/issues/184

Edit: Depends on #152163 but still broken: https://code.blicky.net/yorhel/ncdu/issues/183

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[balsoft]

I think this is because upstream requires Zig 0.9.0 specifically, and we have 0.8.1 in nixpkgs.

[Atemu]

Unfortunately, that's also broken: https://code.blicky.net/yorhel/ncdu/issues/183

[Atemu]

Unfortunately, due to #86299 preventing zig from working, this update would prevent mac users from using ncdu which is a major regression for me and many others who often use this tool.

We would have to keep the old ncdu around and make it default for mac users if we don't want to regress. This might be a good idea anyways since the ncdu 2.0 introduces new features like color some users might not want.

@toonn do you know whether the system libraries issue will be resolved any time soon?

[booniepepper]

this update would prevent mac users from using ncdu which is a major regression for me and many others who often use this tool.

Oh ... that's no good

[SuperSandro2000]

If XDG_CACHE_HOME is unset it should fallback to $HOME/.cache. So creating $HOME should be enough.

[Atemu]

Is there an idiomatic way of doing that?

[SuperSandro2000]

That should be done at the program level otherwise the implementation is wrong.

[Atemu]

We set $HOME to homeless-shelter in Nixpkgs though, don't we?

[andrewrk]

Unfortunately, due to #86299 preventing zig from working, this update would prevent mac users from using ncdu which is a major regression for me and many others who often use this tool.

This issue looks like it has been fixed in zig 0.9.0. Let me confirm this...

Edit: oops, never mind, I thought that was a zig issue for a moment 😅

Edit2: OK but I am curious why this issue would prevent Zig from working. Zig minimally depends on the system that it runs on, and thus tends to work regardless of weird system configurations. What's the issue specifically?

[Atemu]

Next to the broken declaration in Zig's meta is a link to the issue I mentioned, so it's probably due to dependence on some macOS system library. You'd know better than me exactly what parts of a system zig depends on though ;)

[mkg20001]

Would it be an idea to publish this as ncdu_2, rename the current one to ncdu_1 and then add an alias that uses v1 on mac and v2 on linux?

[bbjubjub2494]

Agree with the side-by-side packaging. 2.0 won't fully replace 1.x for some time so we should keep it for a bit. According to upstream,

I will continue to maintain the C version of ncdu for as long as there are people who use it.

I think the system-dependent alias is too much magic though. Best to keep ncdu = ncdu_1 everywhere for least surprise.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 152163 run on x86_64-linux 1

1 package built:

• ncdu_2