Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmPackages: fix nodejs packages #152764

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Dec 30, 2021

Fixes regression caused by
4c60ee3da1e3a9c2441ebeb1c755049555624924 (pull: #142915)
following patch of nodePackages using nodejs-14_x
2c3b3e69ad3306fa0711eebdac98e010c7a2d6aa (pull: #149120)

- clenups and updates in generate-node-packages.sh
- specify nodejs version in default.nix

This makes elmPackages.* build with nodejs-14
which resolves the issue with npm installation failing

resolves #152745

cc @jerith666 for review

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Related:

@turboMaCk turboMaCk changed the title elmPackages: fix nodejs packahes elmPackages: fix nodejs packages Dec 30, 2021
    Fixes regression caused by
    4c60ee3 (pull: NixOS#142915)
    following patch of nodePackages using nodejs-14_x
    2c3b3e6 (pull: NixOS#149120)

    - clenups and updates in generate-node-packages.sh
    - specify nodejs version in default.nix

    This makes elmPackages.* build with nodejs-14
    which resolves the issue with npm installation failing
@jerith666
Copy link
Contributor

Belatedly, this looks great and fixes the build for me -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elmPackages - broken nodejs builds
2 participants