gst-plugins-base: enable graphene and re-enable gstgl on aarch64-darwin #223248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
dasj19,
7c6f434c,
hedning,
jtojnar,
matthewbauer,
amaxine and
bobby285271
lilyinstarlight
force-pushed
the
fix/gst-plugins-base-darwin-gstgl
branch
from
b93b985
to
8bbb9ca
Compare
|
Well it looks like although the original issue that the comment mentions is no longer present, it doesn't actually work without the darwin SDK bump and trying to build with a newer SDK than default for So until the x86_64-darwin SDK gets bumped, I guess we'll just leave gstreamer-gl disabled on x86_64-darwin for now (but it seems fine enabled for aarch64-darwin) When I make the gst-plugins-rs PR, I'll just have it disable the specific plugins that depend on gstreamer-gl (and have it hacky-patch it out of meson.build) and make a TODO note to revisit after the darwin SDK bump |
lilyinstarlight
changed the title
|
Is there a PR/issue for the SDK bump you can link to? Is it currently in staging? |
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Graphene is packaged now and gstreamer-gl is no longer broken on darwin. This is needed for some plugins in
gst-plugins-rs. I also re-enabledmedia-gstreamerin gtk4 on darwin since theoretically it should work now and I can confirm it builds fine on aarch64-darwinThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)