Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.hacl-star-raw: fix build #229896

Merged
merged 1 commit into from
May 4, 2023

Conversation

ulrikstrid
Copy link
Member

Description of changes

Fixes build of hacl-star-raw and subsequently ligo

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member

wegank commented May 4, 2023

@ofborg build ocamlPackages.hacl-star-raw

@ulrikstrid
Copy link
Member Author

Result of nixpkgs-review pr 229896 run on x86_64-linux 1

5 packages built:
  • ligo
  • ocamlPackages.hacl-star
  • ocamlPackages.hacl-star-raw
  • ocamlPackages.tezos-plompiler
  • ocamlPackages.tezos-plonk

@wegank
Copy link
Member

wegank commented May 4, 2023

For the x86_64-darwin failure, probably override stdenv with darwin.apple_sdk_11_0.stdenv?

@ulrikstrid
Copy link
Member Author

For the x86_64-darwin failure, probably override stdenv with darwin.apple_sdk_11_0.stdenv?

That seems reasonable. In the bigger picture it might make sense to move all of nixpkgs to a newer apple sdk since the currently default one is quite old right?

@ulrikstrid ulrikstrid deleted the ulrikstrid--fix-hacl-star-raw branch May 4, 2023 14:41
@wegank
Copy link
Member

wegank commented May 4, 2023

That seems reasonable. In the bigger picture it might make sense to move all of nixpkgs to a newer apple sdk since the currently default one is quite old right?

I hope #101229 will be fixed for 23.11 or 24.05, but I'm not optimistic about it at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants