Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sxhkd: apply patch for multiple layouts #243962

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

ncfavier
Copy link
Member

The recent upgrade past xkeyboardconfig 2.37 causes an issue where sxhkd will get confused if multiple keyboard layouts are used: baskerville/sxhkd#289

I have confirmed with xkeyboardconfig upstream that this is the right fix, but I don't expect sxhkd upstream to be reactive and this is a pretty annoying bug.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The recent upgrade past xkeyboardconfig 2.37 causes an issue where sxhkd
will get confused if multiple keyboard layouts are used: baskerville/sxhkd#289
@ofborg ofborg bot requested review from AndersonTorres and vyp July 17, 2023 12:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 17, 2023
@AndersonTorres
Copy link
Member

Should we fork this?

@ncfavier
Copy link
Member Author

Fork sxhkd? It's a bit early for that, I think?

@AndersonTorres
Copy link
Member

Indeed.

@AndersonTorres AndersonTorres merged commit 5136088 into NixOS:master Jul 17, 2023
@ncfavier ncfavier deleted the sxhkd branch July 18, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants