-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trashy: Generate and install man page #260782
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -17,7 +17,10 @@ rustPlatform.buildRustPackage rec { | |||||||||||||||||||||
installShellCompletion --cmd trash \ | ||||||||||||||||||||||
--bash <($out/bin/trash completions bash) \ | ||||||||||||||||||||||
--fish <($out/bin/trash completions fish) \ | ||||||||||||||||||||||
--zsh <($out/bin/trash completions zsh) \ | ||||||||||||||||||||||
--zsh <($out/bin/trash completions zsh) | ||||||||||||||||||||||
$out/bin/trash manpage > trash.1 | ||||||||||||||||||||||
cp trash.1 trashy.1 | ||||||||||||||||||||||
installManPage trash.1 trashy.1 | ||||||||||||||||||||||
Comment on lines
+21
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Considering oberblastmeister/trashy#106 is merged, will this work?
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You may have to bump to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice catch! I meant to comment on this PR about that trashy PR getting merged. Maybe we should just wait until trashy gets a new release? Is it normal to do an unstable version bump for a package that has a release cadence? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's discouraged, and cherry picking a backward incompatible change as a patch without indicating so in the version is also disingenuous. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the release will take too long, then consider this in the meanwhile
Suggested change
|
||||||||||||||||||||||
''; | ||||||||||||||||||||||
|
||||||||||||||||||||||
meta = with lib; { | ||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #308283