Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkwarden #297619

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Add linkwarden #297619

wants to merge 13 commits into from

Conversation

EricTheMagician
Copy link
Contributor

Description of changes

This is a work in progress.
It generally works. It definitely needs some clean up because some steps are in the package, and some other steps are in the nixos module. Some of the build steps really does need to be in the module as it depends on the runtime environment variables.

I'm not impressed by the fact that I needed to set ignoreHTTPSErrors as it couldn't parse https otherwise

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 21, 2024
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jun 1, 2024
@adamcstephens
Copy link
Contributor

Are you still working on this?

@EricTheMagician
Copy link
Contributor Author

Are you still working on this?

occasionally. there's some deployment things that I'm not sure how to resolve.

@EricTheMagician EricTheMagician force-pushed the linkwarden branch 3 times, most recently from 5b7540d to eaa226a Compare September 15, 2024 21:52
@jvanbruegge
Copy link
Contributor

I did not see this at first, but I also packaged linkwarden and have a module + test that I have been running myself for some weeks now: #347353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants