-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linkwarden #297619
Draft
EricTheMagician
wants to merge
13
commits into
NixOS:master
Choose a base branch
from
EricTheMagician:linkwarden
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add linkwarden #297619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Mar 21, 2024
Are you still working on this? |
occasionally. there's some deployment things that I'm not sure how to resolve. |
EricTheMagician
force-pushed
the
linkwarden
branch
3 times, most recently
from
September 15, 2024 21:52
5b7540d
to
eaa226a
Compare
return a version or something
EricTheMagician
force-pushed
the
linkwarden
branch
from
September 22, 2024 18:59
eaa226a
to
f70d4f2
Compare
I did not see this at first, but I also packaged linkwarden and have a module + test that I have been running myself for some weeks now: #347353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (new)
This PR adds a module in `nixos/`
8.has: module (update)
This PR changes an existing module in `nixos/`
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a work in progress.
It generally works. It definitely needs some clean up because some steps are in the package, and some other steps are in the nixos module. Some of the build steps really does need to be in the module as it depends on the runtime environment variables.
I'm not impressed by the fact that I needed to set
ignoreHTTPSErrors
as it couldn't parsehttps
otherwiseThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.