Conversation
jtojnar
added
0.kind: bug
GrahamcOfBorg
added
10.rebuild-darwin: 0
GrahamcOfBorg
added
10.rebuild-linux: 11-100
jtojnar
commented
Dec 2, 2017
Member
Author
There was a problem hiding this comment.
Is binding /nix enough or should I rather bind /nix/store?
Contributor
There was a problem hiding this comment.
Since /nix/var is not needed, we should rather bind /nix/store.
Member
Author
There was a problem hiding this comment.
It this use of passthru okay?
We are patching the xmlcatalog calls in the JH_CHECK_XML_CATALOG macro to use the XML_CATALOG_FILES environment variable instead of a single central catalog file. Since consumers (libraries or applications) are expected to copy the m4 files to their source tree, we need to patch them separately. The files should be identical, though, so we can reuse the patch for gtk_doc. This commit makes the patch available in passthru so the consumer expressions do not need to maintain the long relative path.
Without thumbnailers available, cheese loops endlessly. NixOS#15790
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)