Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch-package: migrate from nodePackages #323295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

patch-package: migrate from nodePackages #323295

wants to merge 1 commit into from
+46 −94

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jun 29, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pyrox0 pyrox0 force-pushed the nodepackages/patch-package-init branch from 1529f6f to 61ad78c Compare June 29, 2024 04:27
@pyrox0 pyrox0 force-pushed the nodepackages/patch-package-init branch from 61ad78c to ab32351 Compare July 13, 2024 20:03
@pyrox0 pyrox0 changed the title patch-package: remove from nodePackages patch-package: migrate from nodePackages Jul 26, 2024
@pyrox0 pyrox0 force-pushed the nodepackages/patch-package-init branch from ab32351 to 886b469 Compare July 29, 2024 05:04
@pyrox0 pyrox0 force-pushed the nodepackages/patch-package-init branch from 886b469 to 547048e Compare August 2, 2024 19:43
@pyrox0 pyrox0 force-pushed the nodepackages/patch-package-init branch from 547048e to 0f4f56b Compare October 17, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nodejs 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyrox0 @wegank