Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qrcode: 0-unstable-2024-06-05 -> 0-unstable-2024-07-18 #329417

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for qrcode is: Small QR-code tool

meta.homepage for qrcode is: https://github.com/qsantos/qrcode

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0-unstable-2024-07-18 in filename of file in /nix/store/5gg0pknd8l86pyfi1kys26kh416rvaxp-qrcode-0-unstable-2024-07-18

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

qrcode
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/5gg0pknd8l86pyfi1kys26kh416rvaxp-qrcode-0-unstable-2024-07-18 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A qrcode https://github.com/r-ryantm/nixpkgs/archive/c20fa33d8b48bb1fb28e82ce8cb9c842e7b2a522.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/c20fa33d8b48bb1fb28e82ce8cb9c842e7b2a522#qrcode

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/5gg0pknd8l86pyfi1kys26kh416rvaxp-qrcode-0-unstable-2024-07-18
ls -la /nix/store/5gg0pknd8l86pyfi1kys26kh416rvaxp-qrcode-0-unstable-2024-07-18/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • qrcode

Maintainer pings

cc @7c6f434c @lucasew for testing.

@lucasew
Copy link
Contributor

lucasew commented Jul 23, 2024

Result of nixpkgs-review pr 329417 run on x86_64-linux 1

1 package built:
  • qrcode

@lucasew
Copy link
Contributor

lucasew commented Jul 23, 2024

I think it's broken

It's, in my machine, generating a qrcode with inverted colors

Fix: qsantos/qrcode#8

@7c6f434c
Copy link
Member

I guess the question is whether «terminal» means terminal emulator with light or dark background? I mostly encounter default-light-background ones, and there the QR code is in the black-on-white…

(In any case I think we currently have a version with the same behaviour before and after the update)

@7c6f434c
Copy link
Member

@ofborg eval

(the failure was transient)

@lucasew
Copy link
Contributor

lucasew commented Jul 23, 2024

I guess the question is whether «terminal» means terminal emulator with light or dark background? I mostly encounter default-light-background ones, and there the QR code is in the black-on-white…

(In any case I think we currently have a version with the same behaviour before and after the update)

I added the feature so it seems that it's my fault. Maybe that could be a flag that allow the user to invert the colors. At first I am assuming that everyone is using dark terminals because out of the box AFAIK it's true with everything but xterm.

And who uses xterm by option lol

@7c6f434c
Copy link
Member

7c6f434c commented Jul 24, 2024

Well, it is also default for *rxvt and mlterm. And light mode with brightness way down is the way to go! (At least if text on paper is also a thing that happens from time to time)

Inversion switch would be nice, of course (upstream).

@7c6f434c 7c6f434c merged commit 9f6d76a into NixOS:master Jul 24, 2024
28 of 30 checks passed
@r-ryantm r-ryantm deleted the auto-update/qrcode branch July 24, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants