fh: 0.1.10 -> 0.1.16, fix build #331327

ghpzin · 2024-07-31T16:01:03Z

Description of changes

Changelog:
DeterminateSystems/fh@v0.1.10...v0.1.16

Update includes build fixes:

bindgen over version 0.62.2, fixes generating no bindings on clang_18 from extern "C" declarations:
Handle CXCursor_LinkageSpec in Clang 18+ rust-lang/rust-bindgen#2689
rust-lang/rust-bindgen@aaa8883

Log

error[E0425]: cannot find function `parse` in module `crate::ffi`
  --> /build/fh-0.1.10-vendor.tar.gz/nixel/src/parse.rs:23:39
   |
23 |     let parsed = unsafe { crate::ffi::parse(input.as_mut_ptr(), len) };
   |                                       ^^^^^ not found in `crate::ffi`
   |
help: consider importing this function through its public re-export
   |
5  + use crate::parse;
   |
help: if you import `parse`, refer to it directly
   |
23 -     let parsed = unsafe { crate::ffi::parse(input.as_mut_ptr(), len) };
23 +     let parsed = unsafe { parse(input.as_mut_ptr(), len) };
   |

For more information about this error, try `rustc --explain E0425`.
error: could not compile `nixel` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

time over version 0.3.35, fixes 1.80.0 rust issue:
regression: type annotations needed for Box<_> rust-lang/rust#127343

Log

error[E0282]: type annotations needed for `Box<_>`
  --> /private/tmp/nix-build-fh-0.1.10.drv-0/fh-0.1.10-vendor.tar.gz/time/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++
   Compiling serde_path_to_error v0.1.14
For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Fixes #331240 - Build falure: fh

Things done

Add a 👍 reaction to pull requests you find important.

ghpzin · 2024-07-31T18:22:00Z

Result of nixpkgs-review pr 331327 run on x86_64-linux 1

1 package built:

fh

smancill · 2024-08-16T03:09:38Z

Result of nixpkgs-review pr 331327 run on x86_64-darwin 1

1 package failed to build:

fh

Log

fh> buildPhase completed in 2 minutes 26 seconds
fh> Running phase: installPhase
fh> install: skipping file '/dev/fd/63', as it was replaced while being copied
fh> Running phase: fixupPhase
fh> install: skipping file '/dev/fd/63', as it was replaced while being copied
fh> checking for references to /private/tmp/nix-build-fh-0.1.10-vendor.tar.gz.drv-0/ in /nix/store/ihsz16z0b5dk6lflv1g3dvd2ypsrdhwl-fh-0.1.10-vendor.tar.gz...
fh> patching script interpreter paths in /nix/store/ihsz16z0b5dk6lflv1g3dvd2ypsrdhwl-fh-0.1.10-vendor.tar.gz
fh> install: skipping file '/dev/fd/63', as it was replaced while being copied
fh> Running phase: unpackPhase
fh> install: skipping file '/dev/fd/63', as it was replaced while being copied
fh> unpacking source archive /nix/store/fdfigc8c578172j0d5rcvcz30khjcvzc-source
fh> source root is source
fh> Executing cargoSetupPostUnpackHook
fh> unpacking source archive /nix/store/ihsz16z0b5dk6lflv1g3dvd2ypsrdhwl-fh-0.1.10-vendor.tar.gz
fh> Finished cargoSetupPostUnpackHook
fh> Running phase: patchPhase
fh> install: skipping file '/dev/fd/63', as it was replaced while being copied
fh> applying patch /nix/store/grf813fcjrqibjv603hj3w4xd86xl2qc-fix-clang-18-bindgen-version-cargo-lock.patch
fh> patching file Cargo.lock
fh> Executing cargoSetupPostPatchHook
fh> Validating consistency between /private/tmp/nix-build-fh-0.1.10.drv-0/source/Cargo.lock and /private/tmp/nix-build-fh-0.1.10.drv-0/fh-0.1.10-vendor.tar.gz/Cargo.lock
fh> Finished cargoSetupPostPatchHook
fh> Running phase: configurePhase
fh> install: skipping file '/dev/fd/63', as it was replaced while being copied
fh> Running phase: buildPhase
fh> install: skipping file '/dev/fd/63', as it was replaced while being copied
fh> Executing cargoBuildHook
fh> ++ env CC_X86_64_APPLE_DARWIN=/nix/store/k23dj57l3zs3ahh0blhdkj80z295ncv8-clang-wrapper-16.0.6/bin/cc CXX_X86_64_APPLE_DARWIN=/nix/store/k23dj57l3zs3ahh0blhdkj80z295ncv8-clang-wrapper-16.0.6/bin/c++ CARGO_TARGET_X86_64_APPLE_DARWIN_LINKER=/nix/store/k23dj57l3zs3ahh0blhdkj80z295ncv8-clang-wrapper-16.0.6/bin/cc CC_X86_64_APPLE_DARWIN=/nix/store/k23dj57l3zs3ahh0blhdkj80z295ncv8-clang-wrapper-16.0.6/bin/cc CXX_X86_64_APPLE_DARWIN=/nix/store/k23dj57l3zs3ahh0blhdkj80z295ncv8-clang-wrapper-16.0.6/bin/c++ CARGO_TARGET_X86_64_APPLE_DARWIN_LINKER=/nix/store/k23dj57l3zs3ahh0blhdkj80z295ncv8-clang-wrapper-16.0.6/bin/cc CARGO_BUILD_TARGET=x86_64-apple-darwin HOST_CC=/nix/store/k23dj57l3zs3ahh0blhdkj80z295ncv8-clang-wrapper-16.0.6/bin/cc HOST_CXX=/nix/store/k23dj57l3zs3ahh0blhdkj80z295ncv8-clang-wrapper-16.0.6/bin/c++ cargo build -j 8 --target x86_64-apple-darwin --offline --profile release
fh> warning: `/private/tmp/nix-build-fh-0.1.10.drv-0/.cargo/config` is deprecated in favor of `config.toml`
fh> note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
fh> warning: `/private/tmp/nix-build-fh-0.1.10.drv-0/.cargo/config` is deprecated in favor of `config.toml`
fh> note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
fh>    Compiling proc-macro2 v1.0.67
fh>    Compiling unicode-ident v1.0.12
fh>    Compiling libc v0.2.148
fh>    Compiling autocfg v1.1.0
fh>    Compiling cfg-if v1.0.0
fh>    Compiling memchr v2.6.3
fh>    Compiling serde v1.0.188
fh>    Compiling log v0.4.20
fh>    Compiling itoa v1.0.9
fh>    Compiling once_cell v1.18.0
fh>    Compiling parking_lot_core v0.9.8
fh>    Compiling lock_api v0.4.10
fh>    Compiling pin-project-lite v0.2.13
fh>    Compiling thiserror v1.0.48
fh>    Compiling smallvec v1.11.0
fh>    Compiling utf8parse v0.2.1
fh>    Compiling scopeguard v1.2.0
fh>    Compiling tracing-core v0.1.31
fh>    Compiling bytes v1.5.0
fh>    Compiling signal-hook-registry v1.4.1
fh>    Compiling cc v1.0.83
fh>    Compiling mio v0.8.8
fh>    Compiling quote v1.0.33
fh>    Compiling futures-core v0.3.28
fh>    Compiling syn v2.0.37
fh>    Compiling parking_lot v0.12.1
fh>    Compiling fnv v1.0.7
fh>    Compiling ryu v1.0.15
fh>    Compiling glob v0.3.1
fh>    Compiling version_check v0.9.4
fh>    Compiling socket2 v0.5.4
fh>    Compiling num_cpus v1.16.0
fh>    Compiling slab v0.4.9
fh>    Compiling clang-sys v1.6.1
fh>    Compiling spin v0.5.2
fh>    Compiling futures-task v0.3.28
fh>    Compiling ring v0.16.20
fh>    Compiling serde_json v1.0.107
fh>    Compiling untrusted v0.7.1
fh>    Compiling heck v0.4.1
fh>    Compiling regex-syntax v0.7.5
fh>    Compiling hashbrown v0.14.2
fh>    Compiling tinyvec_macros v0.1.1
fh>    Compiling minimal-lexical v0.2.1
fh>    Compiling futures-util v0.3.28
fh>    Compiling lazy_static v1.4.0
fh>    Compiling equivalent v1.0.1
fh>    Compiling nom v7.1.3
fh>    Compiling tinyvec v1.6.0
fh>    Compiling proc-macro-error-attr v1.0.4
fh>    Compiling http v0.2.9
fh>    Compiling indexmap v2.1.0
fh>    Compiling vte_generate_state_changes v0.1.1
fh>    Compiling anstyle-parse v0.2.1
fh>    Compiling regex-automata v0.3.8
fh>    Compiling arrayvec v0.5.2
fh>    Compiling pin-utils v0.1.0
fh>    Compiling colorchoice v1.0.0
fh>    Compiling anstyle-query v1.0.0
fh>    Compiling bindgen v0.69.4
fh>    Compiling percent-encoding v2.3.0
fh>    Compiling ucd-trie v0.1.6
fh>    Compiling syn v1.0.109
fh>    Compiling signal-hook v0.3.17
fh>    Compiling anstyle v1.0.3
fh>    Compiling futures-channel v0.3.28
fh>    Compiling httparse v1.8.0
fh>    Compiling either v1.13.0
fh>    Compiling futures-sink v0.3.28
fh>    Compiling rustls v0.21.7
fh>    Compiling itertools v0.12.1
fh>    Compiling cexpr v0.6.0
fh>    Compiling regex v1.9.5
fh>    Compiling anstream v0.5.0
fh>    Compiling form_urlencoded v1.2.0
fh>    Compiling vte v0.10.1
fh>    Compiling unicode-normalization v0.1.22
fh>    Compiling proc-macro-error v1.0.4
fh>    Compiling aho-corasick v1.1.0
fh>    Compiling rustc-hash v1.1.0
fh>    Compiling bitflags v2.4.0
fh>    Compiling try-lock v0.2.4
fh>    Compiling shlex v1.3.0
fh>    Compiling clap_lex v0.5.1
fh>    Compiling lazycell v1.3.0
fh>    Compiling unicode-bidi v0.3.13
fh>    Compiling regex-syntax v0.6.29
fh>    Compiling idna v0.4.0
fh>    Compiling serde_derive v1.0.188
fh>    Compiling thiserror-impl v1.0.48
fh>    Compiling tracing-attributes v0.1.26
fh>    Compiling tokio-macros v2.1.0
fh>    Compiling tokio v1.32.0
fh>    Compiling tracing v0.1.37
fh>    Compiling futures-macro v0.3.28
fh>    Compiling pest v2.7.3
fh>    Compiling sct v0.7.0
fh>    Compiling rustls-webpki v0.101.5
fh>    Compiling tokio-util v0.7.8
fh>    Compiling pest_meta v2.7.3
fh>    Compiling h2 v0.3.24
fh>    Compiling regex-automata v0.1.10
fh>    Compiling clap_derive v4.4.2
fh>    Compiling ansitok v0.2.0
fh>    Compiling clap_builder v4.4.4
fh>    Compiling want v0.3.1
fh>    Compiling http-body v0.4.5
fh>    Compiling backtrace v0.3.69
fh>    Compiling socket2 v0.4.9
fh>    Compiling num-traits v0.2.17
fh>    Compiling adler v1.0.2
fh>    Compiling eyre v0.6.8
fh>    Compiling overload v0.1.1
fh>    Compiling unicode-width v0.1.10
fh>    Compiling httpdate v1.0.3
fh>    Compiling portable-atomic v1.4.3
fh>    Compiling tower-service v0.3.2
fh>    Compiling gimli v0.28.0
fh>    Compiling hyper v0.14.27
fh>    Compiling nu-ansi-term v0.46.0
fh>    Compiling miniz_oxide v0.7.1
fh>    Compiling clap v4.4.4
fh>    Compiling signal-hook-mio v0.2.3
fh>    Compiling ansi-str v0.8.0
fh>    Compiling addr2line v0.21.0
fh>    Compiling tokio-rustls v0.24.1
fh>    Compiling matchers v0.1.0
fh>    Compiling pest_generator v2.7.3
fh>    Compiling url v2.4.1
fh>    Compiling tracing-serde v0.1.3
fh>    Compiling nixel v5.2.0
fh>    Compiling sharded-slab v0.1.4
fh>    Compiling object v0.32.1
fh>    Compiling thread_local v1.1.7
fh>    Compiling core-foundation-sys v0.8.4
fh>    Compiling bytecount v0.6.7
fh>    Compiling semver v1.0.18
fh>    Compiling indenter v0.3.3
fh>    Compiling base64 v0.21.4
fh>    Compiling rustc-demangle v0.1.23
fh>    Compiling bitflags v1.3.2
fh>    Compiling async-trait v0.1.73
fh>    Compiling unicode-segmentation v1.10.1
fh>    Compiling newline-converter v0.2.2
fh>    Compiling crossterm v0.25.0
fh>    Compiling rustls-pemfile v1.0.3
fh>    Compiling papergrid v0.10.0
fh>    Compiling iana-time-zone v0.1.57
fh>    Compiling tracing-subscriber v0.3.17
fh>    Compiling pest_derive v2.7.3
fh>    Compiling hyper-rustls v0.24.1
fh>    Compiling tabled_derive v0.6.0
fh>    Compiling serde_urlencoded v0.7.1
fh>    Compiling console v0.15.7
fh>    Compiling csv-core v0.1.11
fh>    Compiling encoding_rs v0.8.33
fh>    Compiling owo-colors v3.5.0
fh>    Compiling webpki-roots v0.25.2
fh>    Compiling dyn-clone v1.0.14
fh>    Compiling mime v0.3.17
fh>    Compiling ipnet v2.8.0
fh>    Compiling number_prefix v0.4.0
fh>    Compiling indicatif v0.17.6
fh>    Compiling color-eyre v0.6.2
fh>    Compiling inquire v0.6.2
fh>    Compiling reqwest v0.11.20
fh>    Compiling csv v1.3.0
fh>    Compiling tabled v0.14.0
fh>    Compiling chrono v0.4.31
fh>    Compiling tracing-error v0.2.0
fh>    Compiling handlebars v4.4.0
fh>    Compiling clap_complete v4.4.1
fh>    Compiling nix-config-parser v0.2.0
fh>    Compiling gethostname v0.4.3
fh>    Compiling xdg v2.5.2
fh>    Compiling urlencoding v2.1.3
fh>    Compiling fh v0.1.10 (/private/tmp/nix-build-fh-0.1.10.drv-0/source)
fh>     Finished `release` profile [optimized] target(s) in 2m 37s
fh> Executing cargoInstallPostBuildHook
fh> Finished cargoInstallPostBuildHook
fh> Finished cargoBuildHook
fh> buildPhase completed in 2 minutes 41 seconds
fh> Running phase: checkPhase
fh> install: skipping file '/dev/fd/63', as it was replaced while being copied
fh> Executing cargoCheckHook
fh> ++ cargo test -j 8 --profile release --target x86_64-apple-darwin --offline -- --test-threads=8
fh> warning: `/private/tmp/nix-build-fh-0.1.10.drv-0/.cargo/config` is deprecated in favor of `config.toml`
fh> note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
fh> warning: `/private/tmp/nix-build-fh-0.1.10.drv-0/.cargo/config` is deprecated in favor of `config.toml`
fh> note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
fh>    Compiling tracing v0.1.37
fh>    Compiling rustversion v1.0.14
fh>    Compiling serde_json v1.0.107
fh>    Compiling ring v0.16.20
fh>    Compiling pin-project-internal v1.1.3
fh>    Compiling time-core v0.1.2
fh>    Compiling tower-layer v0.3.2
fh>    Compiling cookie v0.17.0
fh>    Compiling time-macros v0.2.15
fh>    Compiling tokio-util v0.7.8
fh>    Compiling rustls v0.21.7
fh>    Compiling anyhow v1.0.75
fh>    Compiling deranged v0.3.8
fh>    Compiling h2 v0.3.24
fh>    Compiling axum-core v0.3.4
fh>    Compiling sct v0.7.0
fh>    Compiling rustls-webpki v0.101.5
fh>    Compiling pin-project v1.1.3
fh>    Compiling axum v0.6.20
fh>    Compiling tower v0.4.13
fh>    Compiling time v0.3.29
fh>    Compiling axum-macros v0.3.8
fh> error[E0282]: type annotations needed for `Box<_>`
fh>   --> /private/tmp/nix-build-fh-0.1.10.drv-0/fh-0.1.10-vendor.tar.gz/time/src/format_description/parse/mod.rs:83:9
fh>    |
fh> 83 |     let items = format_items
fh>    |         ^^^^^
fh> ...
fh> 86 |     Ok(items.into())
fh>    |              ---- type must be known at this point
fh>    |
fh> help: consider giving `items` an explicit type, where the placeholders `_` are specified
fh>    |
fh> 83 |     let items: Box<_> = format_items
fh>    |              ++++++++
fh>    Compiling serde_path_to_error v0.1.14
fh> For more information about this error, try `rustc --explain E0282`.
fh> error: could not compile `time` (lib) due to 1 previous error
fh> warning: build failed, waiting for other jobs to finish...
error: builder for '/nix/store/3ryzfcmf2r22zwywak1nah130r0ba82k-fh-0.1.10.drv' failed with exit code 101
error: 1 dependencies of derivation '/nix/store/k04bmdbp1qqcbjhwaf2d03lwbnbp6s17-review-shell.drv' failed to build

ghpzin · 2024-08-16T06:57:24Z

It did build before, from logs seems to be hit by rust 1.80.0 update:
#332957

Will try to find out if some newer version of fh builds now without patches.
Or there is a need to also patch time in Cargo.lock manually.

ghpzin · 2024-08-16T12:33:55Z

Converted PR to 0.1.16 update with fix to pass tests on new version.
Versions of bindgen and time in Cargo.lock of 0.1.16 fix both build errors (clang_18 and rust 1.80.0).

ghpzin · 2024-08-16T12:55:06Z

Result of nixpkgs-review pr 331327 run on x86_64-linux 1

1 package built:

fh

SigmaSquadron · 2024-08-16T18:35:26Z

Don't forget to remove the "fixes #<RUST PR ID>" from the description, otherwise the whole issue will be closed prematurely.

ghpzin · 2024-08-16T19:04:02Z

Don't forget to remove the "fixes #<RUST PR ID>" from the description, otherwise the whole issue will be closed prematurely.

Thank you, hopefully fixed by linking closed upstream rust issue instead.

smancill · 2024-08-16T23:37:10Z

It builds on Darwin if I add darwin.apple_sdk.frameworks.SystemConfiguration to buildInputs, but then the tests fail:

Log:

fh> running 18 tests
fh> test cli::cmd::add::flake::test::test_flake_4_add_new_input_before_existing_outputs ... ok
fh> test cli::cmd::apply::tests::test_parse_output_ref ... ok
fh> test cli::cmd::add::flake::test::test_flake_2_rewrite_simple_flake_input ... ok
fh> test cli::cmd::add::flake::test::test_flake_6_doesnt_duplicate_outputs_args ... ok
fh> test cli::cmd::add::flake::test::test_flake_3_rewriting_various_input_formats ... ok
fh> test cli::cmd::add::flake::test::test_flake_1_rewrite_less_simple_flake_input ... ok
fh> test cli::cmd::add::flake::test::test_flake_5_insert_input_into_stylized_inputs_attrs ... ok
fh> test cli::cmd::convert::test::old_flakehub_to_new_flakehub ... ok
fh> test cli::cmd::add::flake::test::test_flake_7_inserts_at_the_bottom ... ok
fh> test cli::cmd::convert::test::nixpkgs_to_flakehub ... FAILED
fh> test cli::cmd::convert::test::nixpkgs_release_to_flakehub ... FAILED
fh> test cli::cmd::tests::flakehub_url_macro ... ok
fh> test cli::cmd::eject::test::flakehub_nixpkgs_to_github ... FAILED
fh> test cli::cmd::eject::test::test_flake8_eject ... FAILED
fh> test cli::cmd::eject::test::versioned_flakehub_to_github ... FAILED
fh> test cli::cmd::eject::test::flakehub_to_github ... FAILED
fh> test cli::cmd::convert::test::test_nixpkgs_from_registry ... FAILED
fh> test cli::cmd::convert::test::test_flake1_convert ... FAILED
fh> failures:
fh> ---- cli::cmd::convert::test::nixpkgs_to_flakehub stdout ----
fh> thread 'cli::cmd::convert::test::nixpkgs_to_flakehub' panicked at /private/tmp/nix-build-fh-0.1.16.drv-0/fh-0.1.16-vendor.tar.gz/system-configuration/src/dynamic_store.rs:154:1:
fh> Attempted to create a NULL object.
fh> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fh> ---- cli::cmd::convert::test::nixpkgs_release_to_flakehub stdout ----
fh> thread 'cli::cmd::convert::test::nixpkgs_release_to_flakehub' panicked at /private/tmp/nix-build-fh-0.1.16.drv-0/fh-0.1.16-vendor.tar.gz/once_cell/src/lib.rs:1311:25:
fh> Lazy instance has previously been poisoned
fh> ---- cli::cmd::eject::test::flakehub_nixpkgs_to_github stdout ----
fh> thread 'cli::cmd::eject::test::flakehub_nixpkgs_to_github' panicked at /private/tmp/nix-build-fh-0.1.16.drv-0/fh-0.1.16-vendor.tar.gz/once_cell/src/lib.rs:1311:25:
fh> Lazy instance has previously been poisoned
fh> ---- cli::cmd::eject::test::test_flake8_eject stdout ----
fh> thread 'cli::cmd::eject::test::test_flake8_eject' panicked at /private/tmp/nix-build-fh-0.1.16.drv-0/fh-0.1.16-vendor.tar.gz/once_cell/src/lib.rs:1311:25:
fh> Lazy instance has previously been poisoned
fh> ---- cli::cmd::eject::test::versioned_flakehub_to_github stdout ----
fh> thread 'cli::cmd::eject::test::versioned_flakehub_to_github' panicked at /private/tmp/nix-build-fh-0.1.16.drv-0/fh-0.1.16-vendor.tar.gz/once_cell/src/lib.rs:1311:25:
fh> Lazy instance has previously been poisoned
fh> ---- cli::cmd::eject::test::flakehub_to_github stdout ----
fh> thread 'cli::cmd::eject::test::flakehub_to_github' panicked at /private/tmp/nix-build-fh-0.1.16.drv-0/fh-0.1.16-vendor.tar.gz/once_cell/src/lib.rs:1311:25:
fh> Lazy instance has previously been poisoned
fh> ---- cli::cmd::convert::test::test_nixpkgs_from_registry stdout ----
fh> thread 'cli::cmd::convert::test::test_nixpkgs_from_registry' panicked at /private/tmp/nix-build-fh-0.1.16.drv-0/fh-0.1.16-vendor.tar.gz/once_cell/src/lib.rs:1311:25:
fh> Lazy instance has previously been poisoned
fh> ---- cli::cmd::convert::test::test_flake1_convert stdout ----
fh> thread 'cli::cmd::convert::test::test_flake1_convert' panicked at /private/tmp/nix-build-fh-0.1.16.drv-0/fh-0.1.16-vendor.tar.gz/once_cell/src/lib.rs:1311:25:
fh> Lazy instance has previously been poisoned
fh> failures:
fh>     cli::cmd::convert::test::nixpkgs_release_to_flakehub
fh>     cli::cmd::convert::test::nixpkgs_to_flakehub
fh>     cli::cmd::convert::test::test_flake1_convert
fh>     cli::cmd::convert::test::test_nixpkgs_from_registry
fh>     cli::cmd::eject::test::flakehub_nixpkgs_to_github
fh>     cli::cmd::eject::test::flakehub_to_github
fh>     cli::cmd::eject::test::test_flake8_eject
fh>     cli::cmd::eject::test::versioned_flakehub_to_github
fh> test result: FAILED. 10 passed; 8 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
fh> error: test failed, to rerun pass `--bin fh`
error: builder for '/nix/store/3v0zxn4r38y7ak22iwwwsdglsl3h8jq8-fh-0.1.16.drv' failed with exit code 101

ghpzin · 2024-08-17T07:25:47Z

Between 0.1.10 and 0.1.16 upstream had changes in these tests and in flake.nix removed skipping them on darwin:
DeterminateSystems/fh@9aaef30
Which would suggests they should work now (?).
Considering package already has __darwinAllowLocalNetworking = true; from before, skipping them on darwin seems like the best idea I have.

pkgs/tools/nix/fh/default.nix

smancill · 2024-08-17T20:33:35Z

Sorry, I double checked, I had sandbox = true enabled, that's the reason the tests were failing. I built again 53c2409de55d91b0f2ba1407cd1053ce98ffc154 (before the force-push and adding SystemConfiguration to build inputs), with sandbox disabled, and it works.

I think there is no need to disable the tests, because the Hydra builders do not use the sandbox? They pass here: https://cache.nixos.org/log/1x47wkyimz0kpbpd0kwrrw00cr3ddanx-fh-0.1.10.drv.

ghpzin · 2024-08-17T22:48:15Z

Removed disabling tests on darwin, moved cacert to buildInputs.

smancill · 2024-08-18T00:27:02Z

Result of nixpkgs-review pr 331327 run on x86_64-darwin 1

1 package built:

fh

pkgs/tools/nix/fh/default.nix

smancill · 2024-08-18T21:51:50Z

@alyssais coud you give your approval so we can merge this.

ghpzin force-pushed the fh-fix-build-with-clang_18 branch from 3f1cac3 to 6edcd5b Compare July 31, 2024 16:03

ofborg bot requested a review from figsoda July 31, 2024 18:06

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 31, 2024

ghpzin marked this pull request as ready for review July 31, 2024 18:25

alesauce mentioned this pull request Aug 7, 2024

chore(flake/nixpkgs): b73c2221 -> c374d94f alesauce/nix-home#427

Merged

ghpzin marked this pull request as draft August 16, 2024 06:57

ghpzin force-pushed the fh-fix-build-with-clang_18 branch from 6edcd5b to 53c2409 Compare August 16, 2024 11:29

ghpzin changed the title ~~fh: fix build with clang_18~~ fh: 0.1.10 -> 0.1.16, fix build Aug 16, 2024

ghpzin marked this pull request as ready for review August 16, 2024 12:56

ghpzin force-pushed the fh-fix-build-with-clang_18 branch from 53c2409 to 506e121 Compare August 17, 2024 07:15

alyssais reviewed Aug 17, 2024

View reviewed changes

pkgs/tools/nix/fh/default.nix Outdated Show resolved Hide resolved

ghpzin force-pushed the fh-fix-build-with-clang_18 branch from 506e121 to 5c24c1e Compare August 17, 2024 22:45

smancill approved these changes Aug 18, 2024

View reviewed changes

smancill added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 18, 2024

alyssais reviewed Aug 18, 2024

View reviewed changes

pkgs/tools/nix/fh/default.nix Outdated Show resolved Hide resolved

fh: 0.1.10 -> 0.1.16, fix build

b9cfdcd

ghpzin force-pushed the fh-fix-build-with-clang_18 branch from 5c24c1e to b9cfdcd Compare August 18, 2024 10:41

alyssais merged commit 7f90752 into NixOS:master Aug 19, 2024
24 of 26 checks passed

ghpzin deleted the fh-fix-build-with-clang_18 branch August 19, 2024 09:17

archer-65 mentioned this pull request Sep 7, 2024

Rust 1.80.0 breaks some packages #332957

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fh: 0.1.10 -> 0.1.16, fix build #331327

fh: 0.1.10 -> 0.1.16, fix build #331327

ghpzin commented Jul 31, 2024 •

edited

Loading

ghpzin commented Jul 31, 2024

smancill commented Aug 16, 2024 •

edited

Loading

ghpzin commented Aug 16, 2024

ghpzin commented Aug 16, 2024

ghpzin commented Aug 16, 2024

SigmaSquadron commented Aug 16, 2024

ghpzin commented Aug 16, 2024

smancill commented Aug 16, 2024 •

edited

Loading

ghpzin commented Aug 17, 2024

smancill commented Aug 17, 2024 •

edited

Loading

ghpzin commented Aug 17, 2024

smancill commented Aug 18, 2024

smancill commented Aug 18, 2024

fh: 0.1.10 -> 0.1.16, fix build #331327

fh: 0.1.10 -> 0.1.16, fix build #331327

Conversation

ghpzin commented Jul 31, 2024 • edited Loading

Description of changes

Things done

ghpzin commented Jul 31, 2024

smancill commented Aug 16, 2024 • edited Loading

ghpzin commented Aug 16, 2024

ghpzin commented Aug 16, 2024

ghpzin commented Aug 16, 2024

SigmaSquadron commented Aug 16, 2024

ghpzin commented Aug 16, 2024

smancill commented Aug 16, 2024 • edited Loading

ghpzin commented Aug 17, 2024

smancill commented Aug 17, 2024 • edited Loading

ghpzin commented Aug 17, 2024

smancill commented Aug 18, 2024

smancill commented Aug 18, 2024

ghpzin commented Jul 31, 2024 •

edited

Loading

smancill commented Aug 16, 2024 •

edited

Loading

smancill commented Aug 16, 2024 •

edited

Loading

smancill commented Aug 17, 2024 •

edited

Loading