-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vencord: 1.9.5 -> 1.10.1 #332423
vencord: 1.9.5 -> 1.10.1 #332423
Conversation
b9dd5fd
to
af2c40d
Compare
I got a hash mismatch building this on
|
That's interesting. I just tried to build it again and it worked? In my case the derivation is also different though: Build log:
|
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
af2c40d
to
4309219
Compare
@FlafyDev @NotAShelf could one of you please take a look and review this PR? |
will do as soon as I get home |
Seems to be causing a hash mismatch:
|
f771392
to
0ff5daa
Compare
This is odd. I wonder if |
likewise:
|
I think this is #8567 |
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
0ff5daa
to
dc011c7
Compare
I have compromised on setting a hardcoded |
Please try again @sersorrel @NotAShelf 🙏 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4523 |
"interesting" log message on build: but, it does build Result of 3 packages built:
|
There's a new release, (v1.10.1), which fixes broken BetterFolders and the like. |
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Result of 3 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my machine, works great :)
Also the package looks to be significantly more maintainable now, which is good.
Seems to be running fine, LGTM. |
Successfully created backport PR for |
Description of changes
Vendicated/Vencord@v1.9.5...v1.10.1
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.