clash-verge-rev: 1.7.5 -> 1.7.7; clash-verge-rev: build from source; clash-verge-rev: add bot-wxt1221 as maintainers; #335998
Conversation
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
from
bf5e348
to
d71f0ce
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4437 |
Bot-wxt1221
changed the title
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
2 times, most recently
from
1ce9719
to
25a095a
Compare
|
Result of 1 package built:
|
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
from
1953083
to
66e5d89
Compare
|
@SuperSandro2000 Done. |
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
from
66e5d89
to
ce0c3cc
Compare
|
@linsui Done |
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
2 times, most recently
from
36cff50
to
557c780
Compare
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
from
557c780
to
742116e
Compare
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
from
742116e
to
6cf0743
Compare
|
@linsui Done. By the way, do you know any way to prefetch pnpmDeps hash? |
|
Please add empty lines between blocks. |
|
We can use linkFarm: linkFarm pname {
"bin/clash-verge-service" = "${service}/bin/clash-verge-service";
"bin/clash-verge" = "${unwrapped}/bin/clash-verge";
"bin/verge-mihomo" = "${mihomo}/bin/mihomo";
"lib/clash-verge/resources/geoip.dat" = "${v2ray-geoip}/share/v2ray/geoip.dat";
"lib/clash-verge/resources/geosite.dat" = "${v2ray-domain-list-community}/share/v2ray/geosite.dat";
"lib/clash-verge/resources/Country.mmdb" = dbip-country-lite.mmdb;
share = "${unwrapped}/share";
} |
|
@linsui linkFarm can't be. clash-verge shouldn't be symbol linked because it find mihomo in it's runtime directory. |
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
from
c0fa42e
to
31ebca1
Compare
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
from
31ebca1
to
822b8f1
Compare
|
@Aleksanaa Done |
…clash-verge-rev: add bot-wxt1221 as maintainers
Bot-wxt1221
force-pushed
the
clash-verge-build-from-source
branch
from
822b8f1
to
766b1bc
Compare
|
@Aleksanaa Ready for review again. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4504 |
|
|
||
| runHook postInstall | ||
| ''; | ||
| } |
There was a problem hiding this comment.
Why need meta? It is only for building clash-verge-rev itself not for user.
There was a problem hiding this comment.
every package should have meta even if it is internal. It is used by hydra to know where to build the package and documents licenses. Please send a follow up PR to add meta.
|
@SuperSandro2000 Why need meta? They will only be used here and make the main package rebuild. |
|
@linsui @Aleksanaa Could you please review again? |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-335998-to-release-24.05 origin/release-24.05
cd .worktree/backport-335998-to-release-24.05
git switch --create backport-335998-to-release-24.05
git cherry-pick -x 766b1bc091deead980c5334e3fbf87b59e71ad07 |
|
Oh no. We shouldn't backport it. I forget it. |
|
|
Description of changes
Just build from source.
#324541 #318525 are doing the same thing but they haven't got any activities.
Anyway, It is already tested by me.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.