-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zutty: init at 0.16-unstable-2024-08-18 #336255
Conversation
i'll test on |
ofBorg fails with I don't know what the problem is. Initially, I thought that this is because |
Ah, I found the issue, I need to use |
b29f8cc
to
652275e
Compare
ofBorg has okay'ed everything except "zutty.passthru.tests on aarch64-darwin" which will be skipped (darwin is not supported). @s0me1newithhand7s This looks good to me now. Could you have a look into this, please? @wegank You had checked #257156 so could you maybe approve & merge here? I think the other PR could then be closed. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4522 |
@JJJollyjim You've been designing (I think) |
@AndersonTorres You had previously merged a terminal emulator-related PR. Could you have a look into this and possibly merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of 1 package built:
|
congrats! |
Description of changes
This PR adds zutty, a terminal emulator.
It is based (and improves) on this previous PR which is now outdated. Compared to that, there are several improvements:
src
has been updated (on GitHub anymore)Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.