-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netdata: 1.46.1 -> 1.47.0 #336919
netdata: 1.46.1 -> 1.47.0 #336919
Conversation
Hi @pedorich-n @RaitoBezarius, any ideas why this does not build successfully? |
Thank you for the PR! I've been meaning to look at the 1.47.0 update, but haven't had a chance yet. I don't fully understand why it's failing, but I think I managed to "narrow it down" to go modules. When I add the following to the (lib.cmakeBool "ENABLE_PLUGIN_GO" false) I don't know if it's normal for Go builds in Nix, but I see a lot of Examples of such logs:
Also, there's this in the logs
|
Apologies I moved away from netdata, so I don't really maintain it anymore. |
What I could deduce is that the go closure has the required modules. I think the issue is that it's not using it as intended. > nix-build -A netdata.netdata-go-modules
Finished at 19:24:03 after 0s
/nix/store/xiapjp91jwhv5kr776pqwsnn0fhpqsw7-netdata-go-plugins-1.47.0-go-modules
> find /nix/store/xiapjp91jwhv5kr776pqwsnn0fhpqsw7-netdata-go-plugins-1.47.0-go-modules -name 'go-flags'
/nix/store/xiapjp91jwhv5kr776pqwsnn0fhpqsw7-netdata-go-plugins-1.47.0-go-modules/github.com/jessevdk/go-flags EDIT Found the culprit https://github.com/netdata/netdata/blob/6a75ccdfd73b6fbf3bb6e2f92887f1e23ede3fd6/packaging/cmake/Modules/NetdataGoTools.cmake#L36C75-L36C107. GOPROXY variable gets manually set.
|
719ee8c
to
8ebc72d
Compare
Error build with enable log management:
|
8ebc72d
to
ffb1e9c
Compare
I've missed that it was removed netdata/netdata#18186 |
But I don't know what is the process of removing something from nixpkgs. Probably it's better to do in a separate PR. |
Description of changes
lm_sensors
as soft dependency netdata.spec/plugin-go: added weak dependency for lm_sensors netdata/netdata#18067logs-management
was remove Remove logs-management plugin. netdata/netdata#18186Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.