slither-analyzer: 0.10.3 -> 0.10.4 | python312Packages.web3: 6.5.0 -> 6.20.3 | python312Packages.pyunormalize: init at 15.1.0 | python312Packages.prettytable: 3.10.1 -> 3.10.2 #337542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellwolf
force-pushed
the
slither-0.10.4
branch
2 times, most recently
from
b89a2bd
to
486621a
Compare
|
@ofborg build slither-analyzer again. |
hellwolf
force-pushed
the
slither-0.10.4
branch
from
486621a
to
e9c948b
Compare
|
$ nixpkgs-review pr 337542 --print-result --build-args "--max-jobs 0 --builders @${HOME}/.config/nix/machines" Result of 4 packages marked as broken and skipped:
20 packages failed to build:
199 packages built:
It doesn't seem that those broken packages are caused by this changset. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4469 |
fabaff
reviewed
Aug 29, 2024
| }; | ||
|
|
||
| # do not run tests | ||
| doCheck = false; |
There was a problem hiding this comment.
Upstream repo seem to contain tests.
Please add pythonImportsCheck.
There was a problem hiding this comment.
Done. Please check everything again.
hellwolf
force-pushed
the
slither-0.10.4
branch
2 times, most recently
from
be17bc6
to
b7ffd50
Compare
|
@ofborg build slither-analyzer |
hellwolf
force-pushed
the
slither-0.10.4
branch
from
b7ffd50
to
706a8c1
Compare
drupol
reviewed
Sep 3, 2024
| hash = "sha256-z0qHRRoPHLdpEaqX9DL0V54fVkovDITOSIxzpzkBtsE="; | ||
| }; | ||
|
|
||
| doCheck = true; |
There was a problem hiding this comment.
Yes, it seems so. I wasn't sure about it myself, and I thought it would be better for the maintainers to not rely on implicit knowledge. I could also remove it, it doesn't seem to be a very unified thing in the code base:
$ git grep 'doCheck = true' pkgs/development/python-modules| wc -l
94
706a8c1
to
8044b70
Compare
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "web3"; | ||
| version = "6.5.0"; | ||
| version = "6.20.3"; | ||
| format = "setuptools"; |
There was a problem hiding this comment.
Can we also convert this to pyproject?
There was a problem hiding this comment.
By doing so, these errors popped up:
> - ckzg not installed
> - hexbytes<0.4.0,>=0.1.0 not satisfied by version 1.2.0
> - lru-dict<1.3.0,>=1.1.6 not satisfied by version 1.3.0
There was a problem hiding this comment.
And as we speak web3 7 doesn't require ckzg anymore.... :/
Upstreams runs faster than the speed of PR.
There was a problem hiding this comment.
Shall we call it for a day, and fix web3 pyproject project in a future PR? I am happy to do it, and I will keep this in mind.
hellwolf
force-pushed
the
slither-0.10.4
branch
from
679f167
to
c652f99
Compare
natsukium
reviewed
Sep 4, 2024
| setuptools-scm | ||
| ]; | ||
|
|
||
| propagatedBuildInputs = [ | ||
| propagatedBuildInputs = with python3Packages; [ |
There was a problem hiding this comment.
Suggested change
| propagatedBuildInputs = with python3Packages; [ | |
| dependencies = with python3Packages; [ |
| ]; | ||
|
|
||
| pythonImportsCheck = [ "pyunormalize" ]; | ||
|
|
There was a problem hiding this comment.
There was a problem hiding this comment.
I thought the tests were enabled by default. I was asked to remove "doCheck = true;" in the previous comments
There was a problem hiding this comment.
Did you read the documentation I showed you?
It says that buildPythonPackage sets doCheck = true by default, and the package needs its own checkPhase. In most cases, just add pytestCheckHook to nativeCheckInputs.
| @@ -29,32 +30,29 @@ buildPythonPackage rec { | |||
| owner = "ethereum"; | |||
| repo = "web3.py"; | |||
| rev = "v${version}"; | |||
| hash = "sha256-RNWCZQjcse415SSNkHhMWckDcBJGFZnjisckF7gbYY8="; | |||
| hash = "sha256-lxCd1Cc79SW8uQrKom9Lqeb7VPuj2nKFlCj51EgSSuk="; | |||
| }; | |||
|
|
|||
| # Note: to reflect the extra_requires in main/setup.py. | |||
| passthru.optional-dependencies = { | |||
There was a problem hiding this comment.
Suggested change
| passthru.optional-dependencies = { | |
| optional-dependencies = { |
| requests | ||
| websockets | ||
| ]; | ||
| propagatedBuildInputs = [ |
There was a problem hiding this comment.
Suggested change
| propagatedBuildInputs = [ | |
| dependencies = [ |
hellwolf
force-pushed
the
slither-0.10.4
branch
3 times, most recently
from
afc033f
to
1e3bcee
Compare
|
what should we do next? |
1 similar comment
|
what should we do next? |
13 tasks
hellwolf
force-pushed
the
slither-0.10.4
branch
from
1e3bcee
to
f571712
Compare
|
converting this to draft, due to that another PR that addresses web3 package issue is currently ongoing https://github.com/NixOS/nixpkgs/pull/337542/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.