mqttx-cli: init at 1.10.1 #337730
Open
mqttx-cli: init at 1.10.1 #337730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pineapplehunter
force-pushed
the
mqttx-cli
branch
3 times, most recently
from
08cd92a
to
a310cc0
Compare
|
added version test |
|
I just realized that the binary name conflicts with mqttx desktop app. |
|
Looking at other repos such as AUR, they don't seem to have mqttx-cli in them.
The first option does not seem good because I can see some users wanting both packages at the same time. The second option seems good IMO but is a breaking change for the users currently using MQTTX desktop app. The third option seems to be the easiest. I'll change this cli app name to |
pineapplehunter
force-pushed
the
mqttx-cli
branch
from
a310cc0
to
f5a59bb
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds mqttx-cli package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.