nixos/services.mosquitto: remove with lib;
#338022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philiptaron
requested changes
Aug 28, 2024
| ${cfg.package}/bin/mosquitto_passwd -U "$file" | ||
| '' | ||
| ++ hashedLines)); | ||
|
|
||
| authPluginOptions = with types; submodule { | ||
| authPluginOptions = with lib.types; submodule { |
There was a problem hiding this comment.
watch out, under this with there's no automatic checking.
There was a problem hiding this comment.
is your suggestion to get rid of this with statement as well?
There was a problem hiding this comment.
No, no suggestion as such.
I've found that when I make errors, it's in the following conditions:
nix-instantiate --parsesucceeds- Because there's a symbol that was previously looked up in the top-level with
- That now is "looked up" in the lower with
- And there's no test of the NixOS module that would exercise the code.
nixosTests.mosquitto exists, so I'll definitely run that before merging. But the other "watch out" signals are there.
Stunkymonkey
force-pushed
the
mosquitto-remove-with-lib
branch
from
e255741
to
481df95
Compare
philiptaron
approved these changes
Aug 28, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #208242
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.