Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signalbackup-tools: 20240816 -> 20240830 #338253

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

malob
Copy link
Member

@malob malob commented Aug 29, 2024

Description of changes

Upadate to latest version. Add new Darwin specific framework dependency and update to using cmake.

Diff: bepaald/signalbackup-tools@2024081...2024083

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@malob malob changed the title signalbackup-tools: 20240816 -> 20240829-3 signalbackup-tools: 20240816 -> 20240829-4 Aug 29, 2024
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we switch to cmake?

@malob malob changed the title signalbackup-tools: 20240816 -> 20240829-4 signalbackup-tools: 20240816 -> 20240830 Sep 2, 2024
@malob
Copy link
Member Author

malob commented Sep 2, 2024

@NickCao, didn't notice he added that. Good call. Done.

@malob malob requested a review from NickCao September 2, 2024 19:39
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop postPatch and installPhase?

@malob
Copy link
Member Author

malob commented Sep 3, 2024

@NickCao, good catch regarding postPatch that was a sloppy oversight on my part. As for installPhase, pretty sure it's needed. Package doesn't build without it.

I'm no CMake expert, but pretty sure this package's CMake config doesn't contain any install instructions or whatever.

@malob malob requested a review from NickCao September 3, 2024 18:50
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM, waiting for ofborg to build on darwin.

@malob
Copy link
Member Author

malob commented Sep 3, 2024

Result of nixpkgs-review pr 338253 run on aarch64-darwin 1

1 package built:
  • signalbackup-tools

@NickCao NickCao merged commit 8119f87 into NixOS:master Sep 3, 2024
24 of 26 checks passed
@malob malob deleted the update-signalbackup-tools branch September 3, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants