Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conduwuit: init at 0.4.6 #339260

Merged
merged 1 commit into from
Sep 4, 2024
Merged

conduwuit: init at 0.4.6 #339260

merged 1 commit into from
Sep 4, 2024

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Sep 3, 2024

Description of changes

I've been a happy conduwuit user for a while now. The most recent release brings along features like authenticated media and Element X (sliding sync) compatibility, which make it a well-suited alternative to conduit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@niklaskorz
Copy link
Contributor Author

niklaskorz commented Sep 3, 2024

Currently getting the following on aarch64-darwin if enableJemalloc is true (works fine without):

       > error: test failed, to rerun pass `-p conduit --bin conduit`
       >
       > Caused by:
       >   process didn't exit successfully: `/private/tmp/nix-build-conduwuit-0.4.6.drv-0/source/target/aarch64-apple-darwin/release/deps/conduit-c8303cb4f61487aa --test-threads=12` (signal: 11, SIGSEGV: invalid memory reference)

Edt: this is a known issue of unprefixed jemalloc on darwin, unfortunately rocksdb does not support prefixed jemalloc so just like upstream conduwuit I disabled jemalloc for rocksdb on darwin

@niklaskorz
Copy link
Contributor Author

Tested on my own homeserver with an existing rocksdb, runs fine

@Aleksanaa Aleksanaa merged commit dbcc712 into NixOS:master Sep 4, 2024
36 of 38 checks passed
@niklaskorz niklaskorz deleted the conduwuit branch September 4, 2024 12:39
girlbossceo added a commit to girlbossceo/conduwuit that referenced this pull request Sep 7, 2024
Signed-off-by: strawberry <strawberry@puppygock.gay>
@nyabinary
Copy link
Contributor

Shouldn't a module be provided too with options? :P

@niklaskorz
Copy link
Contributor Author

Shouldn't a module be provided too with options? :P

Right now conduwuit is compatible with the already existing conduit module. The conduwuit docs also currently recommend using the conduit module and just changing services.conduit.package to conduwuit.

@girlbossceo
Copy link

Personally I would love to see us having our own module so we can detach further from Conduit. I only mention using Conduit's module in the docs because no one's made our own dedicated module. I would be more than eager to remove usage of the Conduit module from the docs if we have our own module.

Hope that clarifies my stance on a conduwuit module.

@niklaskorz
Copy link
Contributor Author

Personally I would love to see us having our own module so we can detach further from Conduit. I only mention using Conduit's module in the docs because no one's made our own dedicated module. I would be more than eager to remove usage of the Conduit module from the docs if we have our own module.

Hope that clarifies my stance on a conduwuit module.

I see, thanks for chiming in! I'll look into it when I return home again next week, if no one else did until then.

@nyabinary
Copy link
Contributor

Personally I would love to see us having our own module so we can detach further from Conduit. I only mention using Conduit's module in the docs because no one's made our own dedicated module. I would be more than eager to remove usage of the Conduit module from the docs if we have our own module.
Hope that clarifies my stance on a conduwuit module.

I see, thanks for chiming in! I'll look into it when I return home again next week, if no one else did until then.

Any updates? :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants