Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{micro-full,micro-with-wl-clipboard,micro-with-xclip}: "init" #339368

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 3, 2024

Description of changes

Closes #338934

Inspired in #338934 and in parallel.

pbsds edit: closes #339075

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres marked this pull request as ready for review September 3, 2024 23:48
Basically, removing all references to clipboard things.
The idea is to wrap them later in another derivation.
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm, can't test due to traveling

@pbsbot
Copy link

pbsbot commented Sep 5, 2024

Result of nixpkgs-review pr 339368 run on x86_64-linux 1

8 packages built:
  • micro
  • micro-full
  • micro-full.man
  • micro-with-wl-clipboard
  • micro-with-wl-clipboard.man
  • micro-with-xclip
  • micro-with-xclip.man
  • micro.man

@pbsds pbsds merged commit e3232bf into NixOS:master Sep 5, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: micro-headless (or similar)
4 participants