system76-power & system76-scheduler: pkgs.linuxPackages -> pkgs

[sjmonson]

Description of changes

Move system76-power and system76-scheduler out of the kernel modules section. Neither of these packages depend on out-of-tree kernel modules.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[cmm]

I'm slightly confused by the linuxPackages attrset: is it for linux-specific packages or (more narrowly) linux-kernel-specific packages? If it's the latter, then this change makes perfect sense.

[sjmonson]

I believe it is the latter. When you put a package in ‘linuxPackages’ you get a version for every kernel. That makes sense if the package builds a dkms module or depends on specific kernels. Neither of these packages have that problem.

[sjmonson]

Sorry to bump this but who is responsible for merging? The affected maintainer has already given approval. I would like to start a new PR to get system76-power updated as its very out of date, but this needs to be in first.

[ahoneybun]

@sjmonson once that is done is there anything I can do to help with getting system76-dkms updated? I'm working on getting a new tagged release out.

[alyssais]

Usually for package moves like this we'd add an alias. There should be some examples already in linux-kernels.nix.

[ahoneybun]

There is a new tag for system76-dkms:

https://github.com/pop-os/system76-dkms/releases/tag/1.0.16

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2042

[alyssais]

Still needs an alias.

[ahoneybun]

Not sure what that is in this context but perhaps @sjmonson knows.

[sjmonson]

@alyssais Sorry I've been busy, I'll get to the aliases tonight.

@ahoneybun This PR is not related to system76-dkms. I'll take a look at it later.

[alyssais]

system76-power is failing to build, but that predates this change, so let's go ahead.

[alyssais]

Would you mind squashing the aliases for each package into the commits that move the attributes? It's nice if there isn't an in-between state where the alias isn't there.