Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowdown: add flag to disable the Darwin sandbox #346945

Merged
merged 2 commits into from
Oct 8, 2024

Commits on Oct 7, 2024

  1. lowdown: add flag to disable the Darwin sandbox

    This is a program written in a memory‐unsafe language that processes
    potentially‐untrusted user input. We shouldn’t disable upstream’s
    sandboxing mechanisms for all downstream consumers without good
    reason.
    
    Although the sandbox API is officially marked as deprecated, it is
    used as the basis for the supported App Sandbox and it is extremely
    unlikely to ever be removed as it is used extensively throughout
    the OS for service hardening and by third parties like the Chrome
    sandbox. Nix itself uses it to sandbox builds, and its lack of support
    for nesting is why this caused problems in the first place. Instead,
    introduce a `lowdown-unsandboxed` package that can be used in the
    `nativeBuildInputs` of Nix builds, while keeping the sandboxed
    version of the program for general use. The name might not be ideal,
    as it remains identical to `lowdown` on non‐Darwin platforms,
    but I couldn’t think of a better one.
    
    See: NixOS#125004
    Closes: NixOS#346933
    emilazy committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    dc32d18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b370a68 View commit details
    Browse the repository at this point in the history