Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collectd: bring back xencpu plugin #347148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hehongbo
Copy link
Contributor

@hehongbo hehongbo commented Oct 7, 2024

Xen is no longer in a broken/unmaintained status, so we can bring the xencpu plugin back easily.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hehongbo
Copy link
Contributor Author

hehongbo commented Oct 7, 2024

cc @bjornfor and @NixOS/xen-project

@hehongbo hehongbo requested review from bjornfor and a team October 7, 2024 18:32
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried this may cause a regression w.r.t #148961. There should be a check to remove the Xen plugin if we're not building for x86_64, at least until #345217 is fixed up and merged.

Also, perhaps the module needs to be updated to run with root permissions if Xen is enabled on the same configuration. (I'm assuming nobody will use this in a domU)

@SigmaSquadron SigmaSquadron added the 6.topic: xen-project The Xen Project hypervisor label Oct 7, 2024
@emilazy
Copy link
Member

emilazy commented Oct 7, 2024

lib.meta.availableOn can be used for availability checks. Enabling functionality in a module should not automatically increase attack surface as root. An assertion or warning is a better idea.

@hehongbo
Copy link
Contributor Author

hehongbo commented Oct 8, 2024

Oops... I accidentally deleted the remote branch I'm working on, I'm sorry.

@hehongbo hehongbo added the 6.topic: xen-project The Xen Project hypervisor label Oct 8, 2024
@github-actions github-actions bot removed the 6.topic: xen-project The Xen Project hypervisor label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants