-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collectd: bring back xencpu plugin #347148
base: master
Are you sure you want to change the base?
Conversation
cc @bjornfor and @NixOS/xen-project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried this may cause a regression w.r.t #148961. There should be a check to remove the Xen plugin if we're not building for x86_64, at least until #345217 is fixed up and merged.
Also, perhaps the module needs to be updated to run with root permissions if Xen is enabled on the same configuration. (I'm assuming nobody will use this in a domU)
|
Oops... I accidentally deleted the remote branch I'm working on, I'm sorry. |
5e93b6e
to
9abcf00
Compare
Xen is no longer in a broken/unmaintained status, so we can bring the
xencpu
plugin back easily.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.