Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snipe-it: 7.0.12 -> 7.0.13 #347933

Merged
merged 2 commits into from
Oct 15, 2024
Merged

snipe-it: 7.0.12 -> 7.0.13 #347933

merged 2 commits into from
Oct 15, 2024

Conversation

patka-123
Copy link
Contributor

@patka-123 patka-123 commented Oct 11, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yayayayaka
Copy link
Member

Taking a look at the NixOS test what changed.

yayayayaka
yayayayaka approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed another commit to fix the test. looking fine now.

@yayayayaka yayayayaka added the backport release-24.05 Backport PR automatically label Oct 14, 2024
@ofborg ofborg bot requested a review from yayayayaka October 14, 2024 12:55
@yayayayaka yayayayaka merged commit 209b7f6 into NixOS:master Oct 15, 2024
29 of 30 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol Awaiting requested review from drupol

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patka-123 @yayayayaka