-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl-graph: init at 0.7.0, add maintainer rksm #348297
Open
rksm
wants to merge
2
commits into
NixOS:master
Choose a base branch
from
rksm:add-kubectl-graph
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rksm
force-pushed
the
add-kubectl-graph
branch
from
October 13, 2024 15:53
30f8385
to
9d842d0
Compare
rksm
changed the title
kubectl-graph: init at v0.7.0, add maintainer rksm
kubectl-graph: init at 0.7.0, add maintainer rksm
Oct 13, 2024
rksm
force-pushed
the
add-kubectl-graph
branch
from
October 13, 2024 15:56
9d842d0
to
ef543e0
Compare
nevivurn
suggested changes
Oct 16, 2024
rksm
force-pushed
the
add-kubectl-graph
branch
from
October 16, 2024 22:34
ef543e0
to
01e7d80
Compare
Thank you for the review @nevivurn! |
rksm
force-pushed
the
add-kubectl-graph
branch
from
October 16, 2024 22:36
01e7d80
to
62cc2b1
Compare
nevivurn
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change, the commit message should not include v
in the version.
Otherwise looks good to me.
rksm
force-pushed
the
add-kubectl-graph
branch
from
October 17, 2024 02:06
62cc2b1
to
8ad2102
Compare
nevivurn
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kubectl-graph, a kubectl plugin for visualizing dependencies between kubernetes resources.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.