Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages.clang: limit backport to clang 15 and 16 #348391

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

reckenrode
Copy link
Contributor

#346043 backported a few patches for SDK 14+ compatibility, but they need to be limited to clang 15. Backporting to older versions would require more work and is unlikely to be needed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label Oct 14, 2024
@RossComputerGuy RossComputerGuy requested a review from a team October 14, 2024 01:09
@reckenrode
Copy link
Contributor Author

I fixed the formatting issue. I don’t think the eval error is related to my change.

@RossComputerGuy
Copy link
Member

I don’t think the eval error is related to my change.

It's not, just rebase and it should go away if the offending package got fixed.

@emilazy emilazy merged commit 7205ddc into NixOS:staging Oct 14, 2024
23 of 25 checks passed
@reckenrode reckenrode deleted the push-wnotovsvwxkt branch October 15, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 101-500 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants