Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "nixos/tests/networking: test nameservers via DHCP" #348464

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Oct 14, 2024

This reverts commit bad5251.

#348305 (comment) Should've known that commit starting with bad will be no good. Fixes nixosTests.networking.networkd.dhcpSimple
https://hydra.nixos.org/build/274843085/nixlog/8/tail

Things done

  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This reverts commit bad5251.

NixOS#348305 (comment)
Should've known that commit starting with `bad` will be no good.
Fixes nixosTests.networking.networkd.dhcpSimple
https://hydra.nixos.org/build/274843085/nixlog/8/tail
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Oct 14, 2024
@vcunat vcunat merged commit a3c0b3b into NixOS:master Oct 14, 2024
7 of 13 checks passed
@vcunat vcunat deleted the p/dhcpcd-hotfix branch October 14, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant