Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make arianvp codeowner of aws #348499

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

arianvp
Copy link
Member

@arianvp arianvp commented Oct 14, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds
Copy link
Member

pbsds commented Oct 14, 2024

i'm not sure if further consensus seeking is warranted or if we just go ahead and merge this

@arianvp
Copy link
Member Author

arianvp commented Oct 14, 2024

I don't think anyone except me is actively maintaining any of this. I'm just going to merge

@arianvp arianvp merged commit f167bda into NixOS:master Oct 14, 2024
27 checks passed
@philiptaron
Copy link
Contributor

I like the norm of removing someone requiring a more involved process unless self-initiated and adding someone being easy and default yes.

@pbsds
Copy link
Member

pbsds commented Oct 14, 2024

If there is already someone else who are also a maintainer i usually ping and wait a bit make sure there isn't any fewds or anything like that. But i agree that adoptions should be free from friction! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants