Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/networking: test nameservers via DHCP #348747

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 15, 2024

Re-add bad5251, this time it should work for both backends.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested with
    • nixosTests.networking.networkd.dhcpSimple
    • nixosTests.networking.scripted.dhcpSimple
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Oct 15, 2024

@GrahamcOfBorg test networking.networkd.dhcpSimple networking.scripted.dhcpSimple

@rnhmjoj rnhmjoj merged commit 1063a12 into NixOS:master Oct 15, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant