Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

present: fix crash caused by dependency #348837

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

errnoh
Copy link
Contributor

@errnoh errnoh commented Oct 15, 2024

fixes #348788

The issue is tracked on vinayak-mehta/present#120, based on that conversation the problem is caused by mistune dependency 3.x. This change changes present to use latest 2.x version instead.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@errnoh
Copy link
Contributor Author

errnoh commented Oct 15, 2024

Oh and question to anyone who might merge this: as this package is broken on 24.05 as well, should this be marked as something that should be backported? (And for 24.11 it's still early enough for the fix to be included, assuming merge within couple weeks?)

@Atemu
Copy link
Member

Atemu commented Oct 17, 2024

If it is entirely broken, this should be backported. There's no point in stability if you cannot use the thing at all.

@vendion could you test this PR and report whether it works for you?

@vendion
Copy link

vendion commented Oct 17, 2024

Yes, this does fix the error that I was getting.

@Atemu Atemu merged commit 2dbeda8 into NixOS:master Oct 18, 2024
27 of 28 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

@Atemu
Copy link
Member

Atemu commented Oct 18, 2024

(Btw, for the future ideally add your reviews using the GH review feature so that committers who filter by reviewed status can discover the PR more easily.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Present tool fails immediately upon launching.
3 participants