Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam (and friends): migrate to by-name, small cleanups all over #349109

Merged
merged 1 commit into from
Oct 16, 2024
Merged

steam (and friends): migrate to by-name, small cleanups all over #349109

merged 1 commit into from
Oct 16, 2024
+24 −105

Conversation

K900
Copy link
Contributor

@K900 K900 commented Oct 16, 2024 •
edited
Loading

  • rename "steam-original" or "steam" to "steam-unwrapped", as that's what it is
  • rename "steam-fhsenv" to "steam", as that's what you actually want
  • remove some no-longer-relevant hacks

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@K900 K900 requested review from mkg20001 and Atemu October 16, 2024 18:52
Atemu
Atemu approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look through the diff and it LGTM.

K900 added a commit to Jovian-Experiments/Jovian-NixOS that referenced this pull request Oct 16, 2024
@K900
treewide: adjust for NixOS/nixpkgs#349109
fa1d015 
- rename overlay args to be consistent
- rename all the steam things to use top level names where possible
- add steam-unwrapped alias for backcompat
K900 added a commit to Jovian-Experiments/Jovian-NixOS that referenced this pull request Oct 16, 2024
@K900
Merge pull request #424 from Jovian-Experiments/fix-for-by-name
e5c6aed 
treewide: adjust for NixOS/nixpkgs#349109
@K900
steam (and friends): migrate to by-name, small cleanups all over
5c33791 
- rename "steam-original" or "steam" to "steam-unwrapped", as that's what it is
- rename "steam-fhsenv" to "steam", as that's what you actually want
- remove some no-longer-relevant hacks
@K900 K900 merged commit bb72b22 into NixOS:master Oct 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu approved these changes

@mkg20001 mkg20001 Awaiting requested review from mkg20001

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: steam 8.has: module (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@K900 @Atemu