Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesa build on darwin now #349186

Open
wants to merge 1 commit into
base: haskell-updates
Choose a base branch
from
Open

mesa build on darwin now #349186

wants to merge 1 commit into from
+0 −14

Conversation

yuanw
Copy link
Contributor

@yuanw yuanw commented Oct 17, 2024 •
edited
Loading

I think haskell packages nanovg and monomer were marked with badPlatforms with darwin were due to mesa cannot build on darwin. #272166 fix mesa build on darwin. I tested build a monomer app on aarch64-darwin, the app renders correctly afaict.
drop mesa related darwin badPlatforms

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yuanw
mesa build on darwin now
c176652 
drop mesa related darwin badPlatforms
@yuanw yuanw marked this pull request as ready for review October 17, 2024 03:00
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 17, 2024
@emilazy
Copy link
Member

emilazy commented Oct 17, 2024

Are you sure these should be depending on Mesa on macOS? Most likely they just want libGL. IIRC cabal2nix might fail to use the cross‐platform alias for some dependencies like libglut.

@emilazy
Copy link
Member

emilazy commented Oct 17, 2024

OK, I had a look and the ones that just depend on libGL should probably be fine, but the ones that pull in both libGL and libX11 are wrong – they’ll need libGLX (which is indeed Mesa on Darwin). I suspect, however, that libX11 should probably be conditional on platform and that these packages can actually work with native OpenGL on macOS.

sternenseemann
sternenseemann reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rsi-break can likely also be dropped from the darwin badplatforms list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann left review comments

@maralorn maralorn Awaiting requested review from maralorn

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuanw @emilazy @sternenseemann