Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazecor: rule for Dygma Defy serial dev #349215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blackxored
Copy link

Bazecor fails to launch with a Dygma Defy connected due to permission errors on a serial device, e.g /dev/ttyACM0, this is owned by the dialout group but rather than have my user be part of that group which feels like a workaround, there's a rule added for the tty subsystem which wasn't covered by the previous rules that are adapted from upstream.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only own a Raise, so I can't test this; but I think @gcleroux has one.

Also, is this something that could be upstreamed to bazecor?

@amesgen
Copy link
Member

amesgen commented Oct 17, 2024

This also seems related: #269513 (comment) cc @gabyx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants