-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services.mysqlBackup: add option to change compression algorithm #364630
Conversation
a1eb7ca
to
23ed34c
Compare
|
acf119f
to
9dea91d
Compare
ok since it looks like the diff is to complicated I'll split it ... ito 3 commits and refactor it a bit |
d298081
to
d28fa69
Compare
@globin could you look at this please :) |
693bebe
to
6420277
Compare
@flokli @infinisil you did review a pull to this file in the passt, would be awesome if somebody could review it :) PS: I would addopt maintinance of this service ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me overall!
6420277
to
fc842d8
Compare
579ba29
to
ceafafc
Compare
ceafafc
to
2a8bbe0
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round
Co-authored-by: Silvan Mosberger <github@infinisil.com>
553b815
to
710b189
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, nice work!
Currently the backup enforces gzip.
But depending on the environment landscape different tools are prevered.
Also with other tools you can save more storage or utilize multiple CPU-Cores better (image is just an example, in this pull here we just add support for zstd and xz)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.