Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services.mysqlBackup: add option to change compression algorithm #364630

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 12, 2024

Currently the backup enforces gzip.

But depending on the environment landscape different tools are prevered.
Also with other tools you can save more storage or utilize multiple CPU-Cores better (image is just an example, in this pull here we just add support for zstd and xz)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 12, 2024
@6543 6543 force-pushed the mysqlBackup_compress-alg branch 2 times, most recently from a1eb7ca to 23ed34c Compare December 12, 2024 16:54
@6543
Copy link
Member Author

6543 commented Dec 12, 2024

I did nixfmt with the nix shell well it is nixfmt-rfc-style now ...

@6543 6543 force-pushed the mysqlBackup_compress-alg branch 3 times, most recently from acf119f to 9dea91d Compare December 14, 2024 03:54
@6543
Copy link
Member Author

6543 commented Dec 24, 2024

ok since it looks like the diff is to complicated I'll split it ... ito 3 commits and refactor it a bit

@6543 6543 force-pushed the mysqlBackup_compress-alg branch 2 times, most recently from d298081 to d28fa69 Compare December 31, 2024 11:58
@6543
Copy link
Member Author

6543 commented Jan 6, 2025

@globin could you look at this please :)

@6543 6543 force-pushed the mysqlBackup_compress-alg branch from 693bebe to 6420277 Compare January 6, 2025 14:45
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 6, 2025
@6543
Copy link
Member Author

6543 commented Jan 7, 2025

@flokli @infinisil you did review a pull to this file in the passt, would be awesome if somebody could review it :)

PS: I would addopt maintinance of this service ...

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me overall!

nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
@6543 6543 force-pushed the mysqlBackup_compress-alg branch from 6420277 to fc842d8 Compare January 8, 2025 13:15
@6543 6543 changed the title services.mysqlBackup: add option to change compression tool services.mysqlBackup: add option to change compression algorithm Jan 8, 2025
@6543 6543 requested a review from infinisil January 8, 2025 13:41
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
@6543 6543 force-pushed the mysqlBackup_compress-alg branch from 579ba29 to ceafafc Compare January 8, 2025 16:57
@6543 6543 requested a review from infinisil January 8, 2025 16:58
@6543 6543 force-pushed the mysqlBackup_compress-alg branch from ceafafc to 2a8bbe0 Compare January 8, 2025 17:01
@6543

This comment was marked as off-topic.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round

nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
nixos/modules/services/backup/mysql-backup.nix Outdated Show resolved Hide resolved
@6543 6543 force-pushed the mysqlBackup_compress-alg branch from 553b815 to 710b189 Compare January 12, 2025 18:51
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Jan 12, 2025
@nix-owners nix-owners bot requested a review from philiptaron January 12, 2025 19:02
@6543 6543 requested a review from infinisil January 13, 2025 00:35
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, nice work!

@infinisil infinisil merged commit 08f39a3 into NixOS:master Jan 13, 2025
43 of 46 checks passed
@6543 6543 deleted the mysqlBackup_compress-alg branch January 13, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants