More string fixes

[piegamesde]

Oh well. So turns out due to a silly mistake, my script previously only ran onto the pkgs subfolder. So here's the remaining fixes for the rest of Nixpkgs. Follow-up to #350296, #350774 and #365186.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[pbsds]

nix-repl> "~ ^(\/[\d]+\.[\d]+\.[\d]+[\.|-][\d]+)?\/(web-apps\/apps\/api\/documents\/api\.js)$"
"~ ^(/[d]+.[d]+.[d]+[.|-][d]+)?/(web-apps/apps/api/documents/api.js)$"

nix-repl> "~ ^(\\/[\\d]+\\.[\\d]+\\.[\\d]+[\\.|-][\\d]+)?\\/(web-apps\\/apps\\/api\\/documents\\/api\\.js)$"
"~ ^(\\/[\\d]+\\.[\\d]+\\.[\\d]+[\\.|-][\\d]+)?\\/(web-apps\\/apps\\/api\\/documents\\/api\\.js)$"

These strike me as broken due to the use of / when i think | was intended

[pbsds]

@SuperSandro2000 via #181258

[infinisil]

Apparently that's how it is in the source, see $(nix-build '<nixpkgs>' -A onlyoffice-documentserver)/etc/nginx/includes/ds-docservice.conf:

#disable caching for api.js
location ~ ^(\/[\d]+\.[\d]+\.[\d]+[\.|-][\d]+)?\/(web-apps\/apps\/api\/documents\/api\.js)$ {
  expires -1;
  # gzip_static on;
  alias  /var/www/onlyoffice/documentserver/$2;
}

[pbsds]

@infinisil, i remember you onboarding someone new to help with lib, but i don't remember who. Please CC them :)

[2xsaiko]

@piegamesde:

@2xsaiko Nix does not know about \b (or any other escape sequence), what's the intent of the regex here?

I didn't write that, but I think this now almost does what is intended. It matches "xfoo =" for term="foo" though. I would write

Suggested change

	configContainsSetting = lines: term: (match "^[^#]*${term}[[:blank:]]*=.*" lines) != null;
	configContainsSetting = lines: term: (match "[[:blank:]]*${term}[[:blank:]]*=.*" lines) != null;

@RaitoBezarius what do you think? Looks like you wrote this originally.

Good to know it doesn't support these escapes.

[piegamesde]

So my version more closely matches the original regex which has the same over-matching, but I'm unsure if it is intended like that or not. I read up on the dovecot configuration docs, still unclear.

[infinisil]

Should ideally hook up CI to check for future regressions, but this seems fine. The manual failure is unrelated, I tested that it works after a merge with recent master.