-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plakativ: init at 0.5.2 #370914
Open
marcin-serwin
wants to merge
2
commits into
NixOS:master
Choose a base branch
from
marcin-serwin:push-lsmzskptkyos
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
plakativ: init at 0.5.2 #370914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
label
Jan 4, 2025
fabaff
reviewed
Jan 4, 2025
pkgs/by-name/pl/plakativ/package.nix
Outdated
description = "Convert a PDF into a large poster that can be printed on multiple smaller pages"; | ||
mainProgram = "plakativ"; | ||
homepage = "https://gitlab.mister-muffin.de/josch/plakativ"; | ||
license = lib.licenses.gpl3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file header doesn't mention "or any later version".
Suggested change
license = lib.licenses.gpl3; | |
license = lib.licenses.gpl3Only; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
marcin-serwin
force-pushed
the
push-lsmzskptkyos
branch
from
January 4, 2025 17:45
81a3f7b
to
71b5733
Compare
|
ethancedwards8
approved these changes
Jan 7, 2025
wegank
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plakativ allows one to stretch a PDF document or raster image across multiple pages that can then be printed on a common inkjet or laser printer, cut and glued together into a larger poster.
https://gitlab.mister-muffin.de/josch/plakativ
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.